Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp186547pxb; Fri, 15 Jan 2021 10:22:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxM8BA2GgrkwGXZXxDRRbiQ6RS2g3NKzdsujN1RME4z1fAWuD3b1D4N8aADw/mk+rZ1iQWT X-Received: by 2002:aa7:c1c6:: with SMTP id d6mr10688281edp.275.1610734944382; Fri, 15 Jan 2021 10:22:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610734944; cv=none; d=google.com; s=arc-20160816; b=ctAItK/mJS23MrbVaOp4CUSwAF8ufTuYIXYThkBLawG3MVqwnJTA1Tq84VrMHU2SXw 8EPyBr3mfSew0exWbYSQs4lkBSJvYdKWA2vh1d2ZDK6TWHeLtr/MxBhCQ+WWBfEesxqf Y4wrApjF541ubGB5srhwNnc904c27CNWONq5d/ZBHfZUVD84KxhgZTAs6ErZBVlatlJK STR+Y3rdHxZtV7eM1lTckUE5aAZczwnz91yP+fhZ6Ha8BZ7C2Uq7ymHLKFyAnJYbTdgu /oNh442THNu7Qu6mJOmJ4ee5pupq6BvEqpcAc+QQsv54vRAPm1xFdk3qS2r4JxaWQYT/ LD3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ouF11XatezVbFMuPjsn7FwMINIqwkDbexOTfYg8EXx4=; b=TAtsdHKp722PqdHYvKOELMNMLdFCDUgvV0Xmc8ZuGPHOYAVuiMpA7PJlz5KslT5zC9 jOsN3uTXPmsLU02mYlbUkIEVXtjxM3333Uji3zwjuLxR84AEPEveVQB+grf2s6YL2FoM J2dI2SI6KYyNB+WMB2jMeN7FZOUeR85w0ANoKFh7PxwPcdYpOR2cAO8QenLYCwOa6A5o oUoNq/R5krFO/wDWwQYkExWae5ofOs5Es688DdZjnsfpOWcvTYT04LZAC9CUX3+S2m+T sQTPyrthOcN72cvybKJNnfAcmmbkcWtrcMyuntoRTWh48XvsYYANMWdx2LHT/LxTqRGQ 4alw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Gk/bU3FB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si4628279eje.690.2021.01.15.10.22.00; Fri, 15 Jan 2021 10:22:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Gk/bU3FB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388615AbhAOSRy (ORCPT + 99 others); Fri, 15 Jan 2021 13:17:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388604AbhAOSRv (ORCPT ); Fri, 15 Jan 2021 13:17:51 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2344C0617A9 for ; Fri, 15 Jan 2021 10:16:29 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id m4so10191165wrx.9 for ; Fri, 15 Jan 2021 10:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ouF11XatezVbFMuPjsn7FwMINIqwkDbexOTfYg8EXx4=; b=Gk/bU3FB1IFDV8OfDg9iJegntzsA+v1LnclxDJt+hsb7B4CgA13LFMBZCzfJN+gsWX 4jHt/mC202CfahomgeLpBcXw0YKenaVlwcrOqoWo95y1alita7OLMMIC+RdNbS7Qnlme yyHeijNl3qu0QtHk9jO4YQ5oI7E2HOTmXVR3w88AFncHrcLrmwit+YFBZYpP7uEpwpgG ANejlTeY5nMYc3NEJMrYiVncAdkanlvh1jpcxOo58Rr/KdyXYyY6RYfgLJrjSrnFIHaP plEjM7ddJ8zkdB1439qXoEo6KAX5vVV4wmUA+W8vCa+yhZumnGW7wPFSBZtfA+6CKRMk KQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ouF11XatezVbFMuPjsn7FwMINIqwkDbexOTfYg8EXx4=; b=thwcY7BHnmgz8Xz/BWW7yU0Y36eGh1CyTRoPDJ/Sdd+KBG0sMkdGt+ngqsBhm/9N77 1tfotHBgwkO5iGGjl8fUm5VNV0ek0BwXhxvXfPKOraMsR6XxgT4mpeBzA3xEh27jCX7B kQO0ebvhVpQz5wWWJngeuDNSKFZksGr1QFUh60IARne4oPWJ2F8trZ/9dLpcLoYLWU6f O8wQ3Q/mofWNKD91DLijbl3sn0HLobmMtXlshgwNHVPcvPjWByLvIrzgEGHgBAImJNI1 HTNjckW2k4hKTbAflKNGWfRaeRDb645ipItVCdwM/i75TLVfg/GfO8Xublk78tMv9Fgd RllA== X-Gm-Message-State: AOAM531BHJwn2qXcbRZIv4G3Necv1POQL4KGt9LVTeFgin7rrHYwyvbo dd5wqBzxSCSzk2AJ6tegwb9vYw== X-Received: by 2002:adf:ef49:: with SMTP id c9mr10085990wrp.172.1610734588620; Fri, 15 Jan 2021 10:16:28 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Daniel Vetter , Eric Anholt , Jesse Barnes , dri-devel@lists.freedesktop.org Subject: [PATCH 16/29] drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks and fix another Date: Fri, 15 Jan 2021 18:15:48 +0000 Message-Id: <20210115181601.3432599-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'dev' not described in 'cdv_intel_lvds_set_backlight' drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'level' not described in 'cdv_intel_lvds_set_backlight' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'dev' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'encoder' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:107: warning: Function parameter or member 'on' not described in 'cdv_intel_lvds_set_power' drivers/gpu/drm/gma500/cdv_intel_lvds.c:298: warning: Function parameter or member 'connector' not described in 'cdv_intel_lvds_get_modes' drivers/gpu/drm/gma500/cdv_intel_lvds.c:480: warning: Function parameter or member 'mode_dev' not described in 'cdv_intel_lvds_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: Jesse Barnes Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c index b62368962c219..5bff7d9e3aa6e 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c @@ -74,7 +74,7 @@ static u32 cdv_intel_lvds_get_max_backlight(struct drm_device *dev) return retval; } -/** +/* * Sets the backlight level. * * level backlight level, from 0 to cdv_intel_lvds_get_max_backlight(). @@ -99,7 +99,7 @@ static void cdv_intel_lvds_set_backlight(struct drm_device *dev, int level) } } -/** +/* * Sets the power state for the panel. */ static void cdv_intel_lvds_set_power(struct drm_device *dev, @@ -291,7 +291,7 @@ static void cdv_intel_lvds_mode_set(struct drm_encoder *encoder, REG_WRITE(PFIT_CONTROL, pfit_control); } -/** +/* * Return the list of DDC modes if available, or the BIOS fixed mode otherwise. */ static int cdv_intel_lvds_get_modes(struct drm_connector *connector) @@ -471,6 +471,7 @@ static bool lvds_is_present_in_vbt(struct drm_device *dev, /** * cdv_intel_lvds_init - setup LVDS connectors on this device * @dev: drm device + * @mode_dev: PSB mode device * * Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). -- 2.25.1