Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: hemantk=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 44829C433ED
Subject: Re: [PATCH v2 2/3] bus: mhi: core: Download AMSS image from
 appropriate function
To:     Bhaumik Bhatt <bbhatt@codeaurora.org>,
        manivannan.sadhasivam@linaro.org
Cc:     linux-arm-msm@vger.kernel.org, carl.yin@quectel.com,
        naveen.kumar@quectel.com, jhugo@codeaurora.org,
        linux-kernel@vger.kernel.org, loic.poulain@linaro.org
References: <1610651795-31287-1-git-send-email-bbhatt@codeaurora.org>
 <1610651795-31287-3-git-send-email-bbhatt@codeaurora.org>
From:   Hemant Kumar <hemantk@codeaurora.org>
Message-ID: <69798940-b1fd-1a8e-40ff-945167ca8734@codeaurora.org>
Date:   Fri, 15 Jan 2021 10:58:28 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1610651795-31287-3-git-send-email-bbhatt@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Bhaumik,

On 1/14/21 11:16 AM, Bhaumik Bhatt wrote:
> During full boot chain firmware download, the PM state worker
> downloads the AMSS image after waiting for the SBL execution
> environment change in PBL mode itself. Since getting rid of the
> firmware load worker thread, this design needs to change and MHI
Can we reword this as current driver does not have firmware load worker 
thread. Basically change is to avoid blocking st worker thread with a 
timeout to get SBL EE before starting AMSS image download. Instead 
trigger AMSS image download directly from the st worker thread when
DEV_ST_TRANSITION_SBL is queued.

> host must download the AMSS image from the SBL mode of PM state
> worker thread instead. Since the full boot chain firmware
> download is associated with a synchronous power up and has MHI
> host waiting for a transition to mission mode with a timeout, we
> can skip creating any devices (or probing any client drivers) in
> SBL mode transition and proceed directly with the AMSS image
> download.
> 
> This means that if MHI host driver is not responsible for the
> AMSS image download or the controller plans to have client
> drivers opening any SBL channels, for example, to download images
> or monitor debug logs for memory allocations or power management,
> the device can be powered up asynchronously.
> 
[..]

Thanks,
Hemant

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project