Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: hemantk=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2E125C433C6
Subject: Re: [PATCH v2 3/3] bus: mhi: core: Process execution environment
 changes serially
To:     Bhaumik Bhatt <bbhatt@codeaurora.org>,
        manivannan.sadhasivam@linaro.org
Cc:     linux-arm-msm@vger.kernel.org, carl.yin@quectel.com,
        naveen.kumar@quectel.com, jhugo@codeaurora.org,
        linux-kernel@vger.kernel.org, loic.poulain@linaro.org
References: <1610651795-31287-1-git-send-email-bbhatt@codeaurora.org>
 <1610651795-31287-4-git-send-email-bbhatt@codeaurora.org>
From:   Hemant Kumar <hemantk@codeaurora.org>
Message-ID: <02206c10-f44f-bf6a-91ce-3cff8e7d0ea8@codeaurora.org>
Date:   Fri, 15 Jan 2021 11:02:28 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1610651795-31287-4-git-send-email-bbhatt@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/14/21 11:16 AM, Bhaumik Bhatt wrote:
> In current design, whenever the BHI interrupt is fired, the execution
> environment is updated. This can cause race conditions and impede any
> ongoing power up/down processing. For example, if a power down is in
> progress and the host has updated the execution environment to a
> local "disabled" state, any BHI interrupt firing later could replace
> it with the value from the BHI EE register.
Can we add what is the real issue observed when mhi_cntrl->ee changed in 
above scenario?
  Another example would be
> that the device can enter mission mode while device creation for SBL
> is still going on, leading to multiple attempts at opening the same
> channel.
Even for this scenario, can we add the real issue that was observed e.g. 
same device was attempting to get created twice and caused xyz issue?
> 
> Ensure that EE changes are handled only from appropriate places and
> occur one after another and handle only PBL or RDDM EE changes as
> critical events directly from the interrupt handler. This also makes
> sure that we use the correct execution environment to notify the
> controller driver when the device resets to one of the PBL execution
> environments.
> 
[..]

Thanks,
Hemant
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project