Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750992AbWIMIae (ORCPT ); Wed, 13 Sep 2006 04:30:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751700AbWIMIae (ORCPT ); Wed, 13 Sep 2006 04:30:34 -0400 Received: from wx-out-0506.google.com ([66.249.82.230]:48633 "EHLO wx-out-0506.google.com") by vger.kernel.org with ESMTP id S1750989AbWIMIad (ORCPT ); Wed, 13 Sep 2006 04:30:33 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=e7fpChI9rSm/4+rwHQ5AbB18z9j2adLc2x/BZlgGKkwa/QXVEYPOhYbD+tNNhpTwUXvxoCZOaiwTOEQFeLEvRc4zxOS9uqHr8w/e506zDs5fxHMn9xWosUR/53oKQC7AiDgQYU/MDeGYXRRU+CkpA6+YWW1VmjGA+XU5xGQzLYE= Message-ID: <9e0cf0bf0609130130s5cc1d85aycbad1dee3682c79d@mail.gmail.com> Date: Wed, 13 Sep 2006 11:30:32 +0300 From: "Alon Bar-Lev" To: "Haavard Skinnemoen" Subject: Re: [PATCH 05/26] Dynamic kernel command-line - avr32 Cc: "Andrew Morton" , linux-kernel@vger.kernel.org In-Reply-To: <20060913102237.1e81b419@cad-250-152.norway.atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200609040115.22856.alon.barlev@gmail.com> <200609040118.06291.alon.barlev@gmail.com> <20060907093111.1bf57c61@cad-250-152.norway.atmel.com> <9e0cf0bf0609070921k7a96f9f7x1605a66745feef9f@mail.gmail.com> <20060913102237.1e81b419@cad-250-152.norway.atmel.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2402 Lines: 63 Thanks! Can you please sign-off the patch? On 9/13/06, Haavard Skinnemoen wrote: > On Thu, 7 Sep 2006 19:21:17 +0300 > "Alon Bar-Lev" wrote: > > > On 9/7/06, Haavard Skinnemoen wrote: > > > > > On Mon, 4 Sep 2006 01:18:04 +0300 > > > Alon Bar-Lev wrote: > > > > > > > > > > > 1. Rename saved_command_line into boot_command_line. > > > > 2. Set command_line as __initdata. > > > > > > I should probably start using that parse_early_param() stuff, > > > though. I'll update this patch if I do. > > The patch "AVR32: Use parse_early_param" does that. Here's an updated > version of your patch that goes on top of that one. > > --- > arch/avr32/kernel/setup.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c > =================================================================== > --- linux-2.6.18-rc5-mm1.orig/arch/avr32/kernel/setup.c 2006-09-07 10:05:07.000000000 +0200 > +++ linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c 2006-09-07 10:30:00.000000000 +0200 > @@ -44,7 +44,7 @@ struct avr32_cpuinfo boot_cpu_data = { > }; > EXPORT_SYMBOL(boot_cpu_data); > > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; > > /* > * Should be more than enough, but if you have a _really_ complex > @@ -202,7 +202,7 @@ __tagtable(ATAG_MEM, parse_tag_mem); > > static int __init parse_tag_cmdline(struct tag *tag) > { > - strlcpy(saved_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE); > + strlcpy(boot_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE); > return 0; > } > __tagtable(ATAG_CMDLINE, parse_tag_cmdline); > @@ -317,7 +317,7 @@ void __init setup_arch (char **cmdline_p > init_mm.end_data = (unsigned long) &_edata; > init_mm.brk = (unsigned long) &_end; > > - strlcpy(command_line, saved_command_line, COMMAND_LINE_SIZE); > + strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE); > *cmdline_p = command_line; > parse_early_param(); > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/