Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vlB29pk6gw7Ezy18fFgSGJX3yN7ykynA4hOtvMk+xGHc49xW8Yw7LbSYrF+ObtxottX7V0Ybfh
 FNCpy/2gSffPzEBXT6zUK1jI5OpYWydoteLqTDXNixfPx1P1m71O1C2sr464T2o69NkjndcTPm
 7Z5GWeMYAxEX0LlTT28Yk+SxZF0ibaKhgpiGmGE3rNJqTagCA8jnthAoAmYi6txyYaZYRH/59S
 SPa43nWb8+1xbHNYZQtRsxTyrgJF8FYFXed5eFH+cBynyYqJAN0WLQqWvv0SwGs94vf40RrKIW
 M3s=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>, "kjlu@umn.edu" <kjlu@umn.edu>
CC:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.de>,
        Jan Kara <jack@suse.cz>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Ming Lei <ming.lei@redhat.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Fix an error handling in add_partition
Thread-Topic: [PATCH] block: Fix an error handling in add_partition
Thread-Index: AQHW69oGPNdrRWfzgEisqwMAdsdShA==
Date:   Sat, 16 Jan 2021 08:18:04 +0000
Message-ID: <BYAPR04MB4965E41A9C690FA11883469A86A60@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20210116072802.21940-1-dinghao.liu@zju.edu.cn>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cd3c2d9-8821-42bc-ea68-08d8b9f73fb0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2021 08:18:04.8147
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wNHVjBGXdQ4JsJRgiYaaweZeG/9bl7qDcTH5T+Wq8DhZJ6mH50N6eO6otIpaqaTQEV1cagH8DTaqikUowvwTFUoixxn5GwBQceHKmF425g0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4983
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/15/21 11:34 PM, Dinghao Liu wrote:=0A=
> Once we have called device_initialize(), we should=0A=
> use put_device() to give up the reference on error,=0A=
> just like what we have done on failure of device_add().=0A=
>=0A=
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>=0A=
Please consider having following commit message, since above=0A=
commit message is looking odd from what we have in the tree :-=0A=
=0A=
=0A=
Once we have called device_initialize(), we should use put_device() to=0A=
give up the reference on error, just like what we have done on failure=0A=
of device_add().=0A=
=0A=
=0A=
Also have you tested this patch with the with generating appropriate error =
?=0A=
=0A=