Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp588082pxb; Sat, 16 Jan 2021 00:23:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwng4+YK1/Fotf5gTsx1zAJDGMoyq55WCDqvGwGYJDrP2sESPRBwbvGNMJc5x1VKLz0mpe5 X-Received: by 2002:a50:f1c7:: with SMTP id y7mr12775337edl.184.1610785433565; Sat, 16 Jan 2021 00:23:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610785433; cv=none; d=google.com; s=arc-20160816; b=mixrgw4+LCwVqQrZGgNj3WBXFTACuPRhAYyHwvQIWYKYY4LMuSvSQpU3w2KQuqAH8g SKPEWnlJwRareuo3K+xN6BpezLhDIO93cotz0Wh/86V40SkbsYPUKVcr1oqppbnryHB7 DP+9fvWazbe3y0DsXUMPWBCkzPiqCN55IkPDf4ZZZ4pKGF/ZIJ7YTwRuUUCGANN6eU5W 41vi06FiW9MSLLu7TjdjQfwLXE/V6qH5zcOSGdEIGrbknGch9e3vPPAyb0WDUtcSPm4e JYV21hM5lbF7Y6HfUiZR8V7iDuELmg9cxA7/WFu+YmeVDhV3lPwTmJg8BIlRWzlnaugm wDUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=3Snmz5aoetzspgSg0v4s2heE4MPXQoXt1HK9usloxd4=; b=B3ivzP6DLVBFT/1NEjB/u7KickEDhDEv/e1vPryPit+vL8xrvdABvBt/33i/tf9atP ejsACQ3WmkWIBQHy2ITabB5bNugnpvP4ZZikivjcPOi1mAIzkP9YERqrp+0nHDXTc95a ZUNEZpmXsHsiYKDD+GIY8ZcT7GRcLL8Ng6luOVCQJOxFet7b9ehYGgr+06J1qQ9WYFma oJ7iH3B28TkjHuzLizxIMoTMQ8HVEyndwWs0uuM++KkOkkvvC/xEuEW+SaD7OiWVQyeg CLccqVDSeyux4ZahG3RS6U17GxOz6YzFMVU8fzC3hYMelljU7Z38cNuMNxZ4rQ5nLYKd 6qXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gw11si4690137ejb.414.2021.01.16.00.23.30; Sat, 16 Jan 2021 00:23:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbhAPIUW convert rfc822-to-8bit (ORCPT + 99 others); Sat, 16 Jan 2021 03:20:22 -0500 Received: from mga07.intel.com ([134.134.136.100]:29856 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbhAPIUV (ORCPT ); Sat, 16 Jan 2021 03:20:21 -0500 IronPort-SDR: lG1AtSoZE6MxmB+hRogZYLFmsN1oPlkxyKyjPNTK0ZFQnSk85wa9OvcneoF3J0JxmGmb3mJLPF soQCzMmKqYNw== X-IronPort-AV: E=McAfee;i="6000,8403,9865"; a="242721406" X-IronPort-AV: E=Sophos;i="5.79,351,1602572400"; d="scan'208";a="242721406" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2021 00:19:38 -0800 IronPort-SDR: Eg0Toc1M9TeXnMX6NPF3iACESND5MEmDDPSMYRHZEWdRa1Tt3miaRU0KZZBRJfjMhEyZ/FqgZf BFCWHrBYOWGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,351,1602572400"; d="scan'208";a="346400223" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 16 Jan 2021 00:19:38 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 16 Jan 2021 00:19:37 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 16 Jan 2021 16:19:35 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Sat, 16 Jan 2021 16:19:35 +0800 From: "Zhang, Rui" To: Peter Zijlstra CC: "mingo@redhat.com" , "acme@kernel.org" , "mark.rutland@arm.com" , "alexander.shishkin@linux.intel.com" , "jolsa@redhat.com" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "kan.liang@linux.intel.com" , "ak@linux.intel.com" Subject: RE: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection Thread-Topic: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection Thread-Index: AQHW63mj1W3psy/8iU6QoBa8JyfUwKop5ljg Date: Sat, 16 Jan 2021 08:19:35 +0000 Message-ID: References: <20210115092208.20866-1-rui.zhang@intel.com> <20210115092208.20866-2-rui.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Peter Zijlstra > Sent: Saturday, January 16, 2021 4:03 AM > To: Zhang, Rui > Cc: mingo@redhat.com; acme@kernel.org; mark.rutland@arm.com; > alexander.shishkin@linux.intel.com; jolsa@redhat.com; > namhyung@kernel.org; linux-kernel@vger.kernel.org; x86@kernel.org; > kan.liang@linux.intel.com; ak@linux.intel.com > Subject: Re: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection > Importance: High > > On Fri, Jan 15, 2021 at 05:22:07PM +0800, Zhang Rui wrote: > > In the RAPL ENERGY_COUNTER MSR, only the lower 32bits represent the > > energy counter, and the higher 32bits are reserved. > > > > Add the MSR mask for these MSRs to fix a problem that the RAPL PMU > > events are added erroneously when higher 32bits contain non-zero value. > > Why would these high bits be non-zero? On SPR platform, the high bits of Psys energy counter are reused for other purpose. High bits for other RAPL domains energy counters still return 0. I didn't mention this because I thought this patch should be okay as a generic fix. Thanks, rui