Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1010924pxb; Sat, 16 Jan 2021 15:27:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdOAv5bzLRq+E72/sJ54tk97NAsaMNMwBwdAsKJCf4/XL8mniCquOwpv3qqv6V/1OUCkEg X-Received: by 2002:aa7:cb49:: with SMTP id w9mr15140461edt.357.1610839628833; Sat, 16 Jan 2021 15:27:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610839628; cv=none; d=google.com; s=arc-20160816; b=W3qhQJjSLx+bIyKIITytwMFZi0bpqsQmbl9pYsQHe1Wh9iTa966F/T8t4TOVNYF8En GFZ56gTV7yVslFyezQmFf99+c6ewVWKuXx2bc23CAfXT7X774Soc+6Ice+bkhApF5B8W UT3Cqm2aglLmin8d7PZSEcGjaYS7aRxeHQuETMd2smQM9HO6XsX3cWA8UuX6VCmXDcyL yGBokMVRymXl1rFAU5nuvv3o1cO7+qN3TxKDrsLmDlTMAz58ZlYL3BhX8kSea2SlkEzn UMyF00wPciYlK60hVHjKuJHoD3dzeadqnQNJqFpjUKXQZnduc4n27+eqQliKUsQ/jB0K Yu1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=jc2zVKX7m2S7svzwMO3x1GfhRcfviS4TwlH7z7kOwlY=; b=Ny+FitoUYyUD3ClTQgy6FzO0dCgo3s/4FLvWIYRsAV4nnkknbdDHibJ4bniQHMu0Ar lCvVcFqlENfTYGj08befZA1YE3EJsfcwu4bIM77jPSqp+M5O7Atd2IoSbw8yPJkLuG/5 CWCm84Adzu1IoaUmis5sqPASzhiZlg0NWFMG3ovjZc9fptwYQFT4znRg1zx+ro/LnhWM YRjMKUAnBUsPfTI5YUofqDCr71iQwB74NieTeT4z84rVKM8PMLE8pIlX5gwt3JsXs4GG Sv4zTj2/3SWdnEYj6VjH6pdTXpgGod7DFPUrm1d5orjN8X0MOTv8Q7sDl2ddHpHHh18F zvTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x60si5831812ede.80.2021.01.16.15.26.45; Sat, 16 Jan 2021 15:27:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbhAPXY0 (ORCPT + 99 others); Sat, 16 Jan 2021 18:24:26 -0500 Received: from retiisi.eu ([95.216.213.190]:51250 "EHLO hillosipuli.retiisi.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbhAPXYY (ORCPT ); Sat, 16 Jan 2021 18:24:24 -0500 Received: from valkosipuli.localdomain (valkosipuli.localdomain [IPv6:fd35:1bc8:1a6:d3d5::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id E053D634C89; Sun, 17 Jan 2021 01:22:40 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1l0uu0-0002pH-Qk; Sun, 17 Jan 2021 01:22:40 +0200 Date: Sun, 17 Jan 2021 01:22:40 +0200 From: Sakari Ailus To: Helen Koike Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, mchehab@kernel.org, hans.verkuil@cisco.com, kernel@collabora.com, linux-kernel@vger.kernel.org, tfiga@chromium.org Subject: Re: [PATCH 3/3] media: videobuf2-v4l2: remove redundant error test Message-ID: <20210116232240.GV850@valkosipuli.retiisi.org.uk> References: <20210114180149.1755892-1-helen.koike@collabora.com> <20210114180149.1755892-4-helen.koike@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114180149.1755892-4-helen.koike@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 03:01:49PM -0300, Helen Koike wrote: > request_fd is validated under media_request_get_by_fd() just below this > check. Thus remove it. > > Suggested-by: Tomasz Figa > Signed-off-by: Helen Koike Reviewed-by: Sakari Ailus -- Sakari Ailus