Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1099231pxb; Sat, 16 Jan 2021 19:12:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzolTcmpcIxwxSlgHJbo4HNWMvkpDsTHhuORuMOHWwVO8DMKCXWmUvFoqYhIWb1LTm/7ESx X-Received: by 2002:a17:906:853:: with SMTP id f19mr4697870ejd.259.1610853167684; Sat, 16 Jan 2021 19:12:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610853167; cv=none; d=google.com; s=arc-20160816; b=Lms/iDqBPdoiZrew0yNqMCo7dEDsk/nCSVsipvcbED4ZiNS4fdH4V+feobUSIVfITp Fc35P4rotI64oYlbT4prBUwtQAi2apfnSEHy8YoMR3pjGS2UrS6n0jgB130L1SJY8akp ehfAcqXO5b797QxQmpw3dijopYnTVzyDConSR9lyASmPgZ8AuJtjHm3sEWaoQKTVS+7C /3GtsZeFwJ5BsY7ZW+Jp1GNTqpgHGW/bifq1lhbwbHt3F7W68+JunBQdn+qL8JX2MX+9 bIEt4Zz/TUk3ohRwUo5Yf/3DLWnWz/kr/3GXMpgAPohVMXyXr6nAnzPo1KZ8Z010XynQ u6Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=zeTd/5wSRuUU3XpnYYlJNmU9MUubS3mTIH0ydLVoMoQ=; b=DvzvvHnaWXwAtYCjB+dltbLF9jPEX4bcX4w2dCIvd4sZUbCARQIjc1vJpn/iysmTWL NtNOYVwM5R/JtajXCgCNQwhx+69fmym4M9ti6jkdG4T8SOIMygruCuaLVyZQ8MtE2XyB /UJt6412SEomuUi7GB177E5URPjXl8FnP6SOSLVj6lPH01QVI77JExPWFZ8MdJPd21t8 lyNEwPjCLq+JsJ0++nLClLYWRe5NpgDw30WLsUH1NgdISI8+bKpTBhAap4pfrLm1vrje YkM9CsdziMDfvtZx62cRsJnKwHT1ZKgBEoetUNWfT3KxJsAAlEvuZzWRap2pJqbcyyjY 5jlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gmJrVA8M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si658437eds.375.2021.01.16.19.12.22; Sat, 16 Jan 2021 19:12:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gmJrVA8M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727637AbhAQDKt (ORCPT + 99 others); Sat, 16 Jan 2021 22:10:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:47370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbhAQDKs (ORCPT ); Sat, 16 Jan 2021 22:10:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPS id EA22C22CAD; Sun, 17 Jan 2021 03:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610853008; bh=A10bUHNwPQbFfEF6e7sKvgF8uTKUzGPK6H6pqguOLXs=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=gmJrVA8MhNdebI4PBlg9FG7k3s5sx49iIRhbeI+azu9ciZZFvKdTj115ppo6Cz17P tNJWyrun2gnhHE0lXgnTIcr6cQAEuK1hKoBxBDoTVqoSNq9aij4rSzt/l8fZSzfJsl MtOmfc79WkFlihNaHqFc0vKko/7yHKdBg4jqQt8oCKsr8xl9ZaZPM8KZ5L/MiOwyH5 5vdZxyrsI1k/3p9p+NfM/9CCMziMvpILUKu0QsKszKy4t2pBeDFTyZ07uaKv1Lf1vg CNmWpVloBBmwRFBzwP/ZeWsDmKu0W0rxT+224NAzOtY/45zuYUxD/WLxqG594Ma2Iy gvhZUguPtclew== Received: from pdx-korg-docbuild-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-1.ci.codeaurora.org (Postfix) with ESMTP id DCDB760658; Sun, 17 Jan 2021 03:10:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161085300789.5035.6945893821776961084.git-patchwork-notify@kernel.org> Date: Sun, 17 Jan 2021 03:10:07 +0000 References: <20210115150354.85967-1-alobakin@pm.me> In-Reply-To: <20210115150354.85967-1-alobakin@pm.me> To: Alexander Lobakin Cc: davem@davemloft.net, kuba@kernel.org, willemb@google.com, linmiaohe@huawei.com, edumazet@google.com, fw@strlen.de, linyunsheng@huawei.com, steffen.klassert@secunet.com, gnault@redhat.com, dseok.yi@samsung.com, kyk.segfault@gmail.com, viro@zeniv.linux.org.uk, elver@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 15 Jan 2021 15:04:40 +0000 you wrote: > Commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for > tiny skbs") ensured that skbs with data size lower than 1025 bytes > will be kmalloc'ed to avoid excessive page cache fragmentation and > memory consumption. > However, the fix adressed only __napi_alloc_skb() (primarily for > virtio_net and napi_get_frags()), but the issue can still be achieved > through __netdev_alloc_skb(), which is still used by several drivers. > Drivers often allocate a tiny skb for headers and place the rest of > the frame to frags (so-called copybreak). > Mirror the condition to __netdev_alloc_skb() to handle this case too. > > [...] Here is the summary with links: - [v2,net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too https://git.kernel.org/netdev/net/c/66c556025d68 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html