Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 10:11:40 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Tang Yizhou <tangyizhou@huawei.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Rientjes <rientjes@google.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH v2] mm, oom: Fix a comment in dump_task
Message-ID: <20210118091140.GA14336@dhcp22.suse.cz>
References: <20210115142314.12903-1-tangyizhou@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210115142314.12903-1-tangyizhou@huawei.com>
Precedence: bulk

On Fri 15-01-21 22:23:14, Tang Yizhou wrote:
> If p is a kthread, it will be checked in oom_unkillable_task() so
> we can delete the corresponding comment.
> 
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Shakeel Butt <shakeelb@google.com>
> Cc: Michal Hocko <mhocko@kernel.org>

Yes, this is outdated for a long time. Thanks
Acked-by: Michal Hocko <mhocko@suse.com>

> ---
> v2: Update Cc list
>  mm/oom_kill.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 04b19b7b5435..9f043ad29554 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -395,9 +395,8 @@ static int dump_task(struct task_struct *p, void *arg)
>  	task = find_lock_task_mm(p);
>  	if (!task) {
>  		/*
> -		 * This is a kthread or all of p's threads have already
> -		 * detached their mm's.  There's no need to report
> -		 * them; they can't be oom killed anyway.
> +		 * All of p's threads have already detached their mm's. There's
> +		 * no need to report them; they can't be oom killed anyway.
>  		 */
>  		return 0;
>  	}
> -- 
> 2.22.0

-- 
Michal Hocko
SUSE Labs