Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1855520pxb; Mon, 18 Jan 2021 01:31:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyukrqUg3A6fOxkUSx65wpFh5hwLX42sAH8Izpr5fbH/ayvdxJZFJ/Hqv6jhitecHu4sube X-Received: by 2002:aa7:dcc9:: with SMTP id w9mr17891317edu.22.1610962287567; Mon, 18 Jan 2021 01:31:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610962287; cv=none; d=google.com; s=arc-20160816; b=CMM2AsNhy+PerLlfFxL9ddilf7FNE6FKItzhxgVBvaM4hlhWJTOZMzkhQ7o6ECb/F4 16A1eVKETnriYhaR9Yf2ZBMEMQj582UliyFdnpO6BRCcjhqhzjQ/+Jfa3uiixWu9+l7I KEPBoF6sXrrx4tLJYMITsu43Q+JWX5iZpdUXGklZ4pDPrLrxvKocA8by0nLV5jmC+u/s uR25dLarDD/y+6N4mhLsSPrnM4//TyIqFu5xvwaCM/DSXn3+l73bApHZRtH5FHWLjSdG sFqb8HQiIuqjIy3jNSjxynZun5LN89WmaWIAqxkwJJfRLc9dLtA856AM7AQ9bJ38nilk atow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=oEgteQ67RbjTMAwvPZis8M4j9IGYHXIhSxdTHCm7e6Y=; b=B9C82b0542MdvwEtXsWOddICJshjSqgZaDI0/IYMmDvxTn2jz88c2RyNL1ie3SJvJm DBeyajnoE5Ob3R7h8CthHf/k2UBQxKpImRIw1GD1Sd+u114z1VZxLjclZAg7NQo3Kyww XSEpO3YnCiBu94+GrQSllRG//kzB1UNqYOEwt0l5vrpRv2hC45aalCUwFAPXKIsMRZTH ojY5IMUFb15qSH+reZETRdSYxOwFZp+JuKFddJtuHock6lqr3JfSN2aXyOFGr44dbrQS pQd47T8vB4+1fK52vMzNNkdJzOqjxdmZ8k/COzuy+V8pYVfZT2KRyIvpy6aXtRuwGif3 wRzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=znpM9cqz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u1si1888673ejg.476.2021.01.18.01.31.04; Mon, 18 Jan 2021 01:31:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=znpM9cqz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388713AbhARJXU (ORCPT + 99 others); Mon, 18 Jan 2021 04:23:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388396AbhARJKt (ORCPT ); Mon, 18 Jan 2021 04:10:49 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F342C0613C1 for ; Mon, 18 Jan 2021 01:10:08 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id p22so16662028edu.11 for ; Mon, 18 Jan 2021 01:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oEgteQ67RbjTMAwvPZis8M4j9IGYHXIhSxdTHCm7e6Y=; b=znpM9cqzm5Ln6b3VgkdhlO8qAGfjcdtnRjxmpGW+BYNOlcMy12I2ngj7lV6nYTV+6Y KCRFIP6LKRjSuW9sPVUgQQi3d92zUUYVM/UJ08ICNB5RbJdLHWv23IPvfLQqWR8jOImW dmBoPBu5StGeMXug6wcaB0p4VO/Fg00zPyBvGFsnf4d0EvRiIdiLfWCCwQOfWeomK+J9 P38hS14PCPaP7dxrVV6X+wEAX6D2aCka5brGNwx9dYdQq0ofLVVSRj7QjCIVKRkhpu9E rPiKYswlTIxCTAh4xqbNR+E6p+A9e0knHLwwHCGsc6oRzojjc9bgcDpRlN+qEo4WDhB7 B0rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oEgteQ67RbjTMAwvPZis8M4j9IGYHXIhSxdTHCm7e6Y=; b=GvHlp3c+wEYyATV6G7hU408fpS2hvOs9tcaBl6kQ7RIA6dH2bDCwPQ+pd7965eEKFO BEZ2IDjy6ttJ/ke8S8M5HZZvHi7er3y42fssg0rk7OJq87cKizesIcwPj3XhUDbn+zIa J6n5ZIo12to22Uk3NuAk+Lqlxil45q5mAgYSy1Frb2w0n3KIws+ZFkVQyOF6jRhuWMVA p6cc6VPXBqhGV7qDpiPM6ZDlwGvmfTaf7XqMqIc4KdqEwvcJT1L6QBZG0kuTdbvG/2RE lDm++txulYEluLWTVnwHoI93dJ6AZbiqk2B9QLeSONOFM8Myxex7TaS3ob+eCWUvU5zP CAOQ== X-Gm-Message-State: AOAM530zlF67weu62ik0lhrwozRngrEmqq5rNQfTYHC3NbCln581f7kf PNbe6tRKaTrH3GAJ/Lkm+rfA4tTU+7T+E6hnW/p0kA== X-Received: by 2002:aa7:dacf:: with SMTP id x15mr18121907eds.134.1610961007258; Mon, 18 Jan 2021 01:10:07 -0800 (PST) MIME-Version: 1.0 References: <20201130142759.28216-1-brgl@bgdev.pl> <20201130202110.62e7f989@archlinux> <20201213120442.3f98814a@archlinux> In-Reply-To: <20201213120442.3f98814a@archlinux> From: Bartosz Golaszewski Date: Mon, 18 Jan 2021 10:09:56 +0100 Message-ID: Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres To: Jonathan Cameron Cc: Anand Ashok Dumbre , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 13, 2020 at 1:04 PM Jonathan Cameron wrote: > > On Fri, 11 Dec 2020 12:15:15 +0000 > Anand Ashok Dumbre wrote: > > > > -----Original Message----- > > > From: Jonathan Cameron > > > Sent: Monday 30 November 2020 8:21 PM > > > To: Bartosz Golaszewski > > > Cc: Lars-Peter Clausen ; Peter Meerwald-Stadler > > > ; Michal Simek ; linux- > > > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > > kernel@vger.kernel.org; Bartosz Golaszewski > > > ; Anand Ashok Dumbre > > > > > > Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres > > > > > > On Mon, 30 Nov 2020 15:27:56 +0100 > > > Bartosz Golaszewski wrote: > > > > > > > From: Bartosz Golaszewski > > > > > > > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: > > > > use devm_krealloc()"). I noticed we can use even more devres helpers > > > > and entirely drop the remove() callback. > > > > > > > > v1 -> v2: > > > > - squash three patches adding more devres calls into one for easier > > > > review > > > > - don't insist on the 80 characters limit > > > > - add a new helper: devm_krealloc_array() and use it > > > > > > > > v2 -> v3: > > > > - drop the devm_krealloc_array() helper > > > > > > > > Bartosz Golaszewski (3): > > > > iio: adc: xilinx: use helper variable for &pdev->dev > > > > iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() > > > > iio: adc: xilinx: use more devres helpers and remove remove() > > > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 157 > > > > ++++++++++++++--------------- > > > > 1 file changed, 74 insertions(+), 83 deletions(-) > > > > > > > > > > Series looks good to me but would like to leave it a little longer to let others > > > take a look at it. That will probably mean it falls into next cycle now. > > > > > > +CC Anand who is looking at another series touching this driver and > > > +might > > > give this one a spin as well. > > > > > > Thanks, > > > > > > Jonathan > > > > Hi Jonathan, Bartosz, > > > > I have tested and reviewed the patch and everything looks good. > > I have another patch series on the same files that might cause conflicts. > > > > Reviewed-by: Anand Ashok Dumbre > > Tested-by: Anand Ashok Dumbre > Thanks, > > Applied to the togreg branch of iio.git and pushed out as testing for > the autobuilders to play with it. > > There was a small amount of fuzz. > > Thanks, > > Jonathan > Hi Jonathan, I still don't see these patches in next - is any action required of me to get this in for the next release? Bartosz