Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 11:13:02 +0200
From:   Eli Cohen <elic@nvidia.com>
To:     Thomas Zimmermann <tzimmermann@suse.de>
CC:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <daniel.vetter@ffwll.ch>, <sam@ravnborg.org>,
        <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        <virtualization@lists.linux-foundation.org>
Subject: Re: Change eats memory on my server
Message-ID: <20210118091302.GB40909@mtl-vdi-166.wap.labs.mlnx>
References: <20210114151529.GA79120@mtl-vdi-166.wap.labs.mlnx>
 <23cf7712-1daf-23b8-b596-792c9586d6b4@suse.de>
 <20210117050837.GA225992@mtl-vdi-166.wap.labs.mlnx>
 <83f74a11-b3c0-db2e-8301-4292d60d803b@amd.com>
 <2ea2630b-8782-c662-91fe-683d8b5d6c99@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <2ea2630b-8782-c662-91fe-683d8b5d6c99@suse.de>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
Precedence: bulk

On Mon, Jan 18, 2021 at 08:54:07AM +0100, Thomas Zimmermann wrote:
> Hi
>=20
> Am 18.01.21 um 08:43 schrieb Christian K=F6nig:
> > Hi Eli,
> >=20
> > have you already tried using kmemleak?
> >=20
> > This sounds like a leak of memory allocated using kmalloc(), so kmemlea=
k
> > should be able to catch it.
>=20
> I have an idea what happens here. When the refcount is 0 in kmap, a new p=
age
> mapping for the BO is being established. But VRAM helpers unmap the previ=
ous
> pages only on BO moves or frees; not in kunmap. So the old mapping might
> still be around. I'll send out a test patch later today.
>=20

Great! Looking forward to test it.

> Best regards
> Thomas
>=20
> >=20
> > Regards,
> > Christian.
> >=20
> > Am 17.01.21 um 06:08 schrieb Eli Cohen:
> > > On Fri, Jan 15, 2021 at 10:03:50AM +0100, Thomas Zimmermann wrote:
> > > > Could you please double-check that 3fb91f56aea4 ("drm/udl: Retrieve=
 USB
> > > > device from struct drm_device.dev") works correctly
> > > Checked again, it does not seem to leak.
> > >=20
> > > > and that 823efa922102
> > > > ("drm/cma-helper: Remove empty drm_gem_cma_prime_vunmap()") is brok=
en?
> > > >=20
> > > Yes, this one leaks, as does the one preceding it:
> > >=20
> > > 1086db71a1db ("drm/vram-helper: Remove invariant parameters from
> > > internal kmap function")
> > > > For one of the broken commits, could you please send us the output =
of
> > > >=20
> > > > =A0=A0 dmesg | grep -i drm
> > > >=20
> > > > after most of the memory got leaked?
> > > >=20
> > > I ran the following script in the shell:
> > >=20
> > > while true; do cat /proc/meminfo | grep MemFree:; sleep 5; done
> > >=20
> > > and this is what I saw before I got disconnected from the shell:
> > >=20
> > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 148208 kB
> > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 148304 kB
> > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 146660 kB
> > > Connection to nps-server-24 closed by remote host.
> > > Connection to nps-server-24 closed.
> > >=20
> > >=20
> > > I also mointored the output of dmesg | grep -i drm
> > > The last output I was able to save on disk is this:
> > >=20
> > > [=A0=A0 46.140720] ast 0000:03:00.0: [drm] Using P2A bridge for confi=
guration
> > > [=A0=A0 46.140737] ast 0000:03:00.0: [drm] AST 2500 detected
> > > [=A0=A0 46.140754] ast 0000:03:00.0: [drm] Analog VGA only
> > > [=A0=A0 46.140772] ast 0000:03:00.0: [drm] dram MCLK=3D800 Mhz type=
=3D7
> > > bus_width=3D16
> > > [=A0=A0 46.153553] [drm] Initialized ast 0.1.0 20120228 for 0000:03:0=
0.0
> > > on minor 0
> > > [=A0=A0 46.165097] fbcon: astdrmfb (fb0) is primary device
> > > [=A0=A0 46.391381] ast 0000:03:00.0: [drm] fb0: astdrmfb frame buffer=
 device
> > > [=A0=A0 56.097697] systemd[1]: Starting Load Kernel Module drm...
> > > [=A0=A0 56.343556] systemd[1]: modprobe@drm.service: Succeeded.
> > > [=A0=A0 56.350382] systemd[1]: Finished Load Kernel Module drm.
> > > [13319.469462] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=A0=A0=
=A0=A0=A0 0=A0=A0=A0 73728
> > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> > > [13320.658386] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=A0=A0=
=A0=A0=A0 0=A0=A0=A0 73728
> > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> > > [13321.800970] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=A0=A0=
=A0=A0=A0 0=A0=A0=A0 73728
> > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> >=20
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>=20
> --=20
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> (HRB 36809, AG N=FCrnberg)
> Gesch=E4ftsf=FChrer: Felix Imend=F6rffer
>=20