Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1881438pxb; Mon, 18 Jan 2021 02:22:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrGcJanm5FZVb3A59W3cvKwSQiJAZf9uIAs60TipFOmtwY6Y2nXafv3/xAhRpK4Ws0UWB4 X-Received: by 2002:aa7:d94b:: with SMTP id l11mr2133060eds.1.1610965344378; Mon, 18 Jan 2021 02:22:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610965344; cv=none; d=google.com; s=arc-20160816; b=YLZldhRQcW0yO5s333QSFtk6+OIoewpYW11qoYqzxQo7ihfaB3A40qpMXu8+TYuLw5 ceoYP8/8OT7ccVJieAfBnzWuTHrCLiOt5Oh1wRGpn7bDVnM9t0+tgyYZ88BdWjY+37qK MJUnTTz9ZBEts8uITbPymtMxb1Q441XOBke1u1pXiW185wXvTWbbZiVzculZUjq4z7dl TdmOFB3DMpXyiZsmr5xb/2wz9phZkmL/Egmu0gZOU0IOSEpx5GoFmRKp5BLg+NunLEbp lGKFkYBABFDdgxMurJ59+x6flr8srIWtNkss95urbJVHdmoWhu24otRZHGmZLGbzd5JJ 2n3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=dF0t9ODzrlcXkrVNJBvlvyC8pFerKE5p0KyDQKyqdhk=; b=cQs1oc9RLFTmK2XcgFFY2EVowS4ilPT35O6+vw7tlVFFmpLsidRclRNCcRfxzUcLzP GVDkOom3LvHWqxlSVquhbER3WgtDrPOT1H0EVb+4OlVdgKpltCLw8IkhOcgF0YMS7Xgh oKGe9Pme+5u8TEg34vYuxJqDStS+h1odm9s58+mRYxU3V0lcgcM4OhSHz/PQwO2abnl4 WgwiCSdQ3obBqtRDnIEecSN6sUsTrrFfaGKkitpecTzAWX5JAmrx2TxJDqQrkJKRkcMg XarrAQiUqZwFzmjZEqLHblDyXjjrI7B69GDvo5UXfHICg/3LNNrmhNA+MlNqrq6WxpsP RdcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pKACODJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k20si7146794edo.493.2021.01.18.02.22.01; Mon, 18 Jan 2021 02:22:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pKACODJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389915AbhARKRT (ORCPT + 99 others); Mon, 18 Jan 2021 05:17:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:37652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389375AbhARJ4p (ORCPT ); Mon, 18 Jan 2021 04:56:45 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D82522228; Mon, 18 Jan 2021 09:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610963765; bh=hAH879fCCZw1dfCtLfrTzmyt6X6aM8UCFrEg1gU8pUU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pKACODJC7FKzF8TgNnaJRUhxSrJSD3VTZ/9rpSTGa0A749r7pjMFpcB0fupmgNYwD 8P53sRRPlsLlnLlu+k5eq25YKtr104pRmMd+eigkzpI7pq9zKUMIy+5XWR9kuosWZN SLJt3eCVx/92huYmILbIM4iAkXF/aZsDu3PO/YVkVFzUFxy52Ab0clb+9Zj63+NqYn xCioDcWu//N8v2MFaIk5IOq9fQCvmEg9p+GT4gZ/Jq4M3nakmUvzl19hcK3TvRdMjC hHLoirWVokaQNWweQ/zqPF2XoJMaM3l6mDo+YErenvl17pxVwIz1Z8Dux+KX9OmpVB Ghl7DkTpyAFYA== Date: Mon, 18 Jan 2021 10:56:02 +0100 (CET) From: Jiri Kosina To: Sanjay Govind cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Pascal.Giard@etsmtl.ca Subject: Re: [PATCH v2] HID: sony: Add support for tilt on guitar hero guitars In-Reply-To: <20201204054526.148299-1-sanjay.govind9@gmail.com> Message-ID: References: <20201130194314.89509-1-sanjay.govind9@gmail.com> <20201204054526.148299-1-sanjay.govind9@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Dec 2020, sanjay.govind9@gmail.com wrote: > From: Sanjay Govind > > This commit adds support for tilt on Standard Guitar Hero PS3 Guitars, and GH3 PC Guitars, mapping it to ABS_RY. > > Note that GH3 PC Guitars are identical, only they use different VID and PIDs. > Also note that vendor id 0x12ba is used by a variety of different rhythm controllers on the ps3. > > Signed-off-by: Sanjay Govind > > Fix some incorrect constants after a refactor I have removed the sentence above and applied, thanks. -- Jiri Kosina SUSE Labs