Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] PM / devfreq: Add sysfs attributes to simple_ondemand
 governor
To:     Chanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Cc:     myungjoo.ham@samsung.com, kyungmin.park@samsung.com
References: <CGME20210115170541epcas1p1b7bc36fb5a4f1b907da5771ca0c37891@epcas1p1.samsung.com>
 <20210115170530.22603-1-lukasz.luba@arm.com>
 <e09da2a0-f4cc-d93e-07a5-3551004fed83@samsung.com>
From:   Lukasz Luba <lukasz.luba@arm.com>
Message-ID: <3b0c23f9-a160-6cbc-e2e1-8b9afd2d094d@arm.com>
Date:   Mon, 18 Jan 2021 09:56:24 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <e09da2a0-f4cc-d93e-07a5-3551004fed83@samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Chanwoo,

On 1/18/21 6:49 AM, Chanwoo Choi wrote:
> Hi Lukasz,
> 
> I has been developed[1] the sysfs attributes for upthreshold and downdifferential.
> But, I has not yet posted it[1]. I'll post my approach with some changes.

Fair enough. Please add me on CC when you post it. I can help you with
reviewing it.

> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-testing&id=e7c59dfb4afebe0c96de54516e9be23d76d96492

Thank you for the link. The code looks pretty good, just use
kstrtouint() instead of sscanf() - checkpatch would not complain.

Regards,
Lukasz