Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1967546pxb; Mon, 18 Jan 2021 05:01:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwevskeVs5UiBzze4Y9EacCnAhFHsirmvZR20ppPQqbkKHrZwYk+JWgLMcXk+JhJ8Ous0ip X-Received: by 2002:a17:907:7346:: with SMTP id dq6mr4899186ejc.237.1610974879304; Mon, 18 Jan 2021 05:01:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610974879; cv=none; d=google.com; s=arc-20160816; b=Jr8crnEWf9YRjguo41dBblhkofZG1iGOz9NWViGXd9hT1WmO+4I+ExgZyReRAwAaaf ijXXzvye3CUuvtlhvxmjeTEC18JymVkV22g5+3H7i14CCpXwHiuk6dwRI0W9DaSa/KSu oZZpdhOWPuH98K48c9UpBEP0SVofko1sV5gvnsSsKgmqHXzjlX653mVJKxRM83YXWgQy z+epaH3bXMpZIoI10LdymyD9SCPbyU89JuzQvy+HQz9qZPOAv0zTTOUeiNesg/RNXfOY 6Z0lxXGfC4LQWrar0qiADoGGvNFmZxUSeiqWK29n32AiBuAAJ/9tQ8cpo7qHF/hjwwT+ 4YiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=0kxBCU1Z1kqYKa2J63wifuN3IA7AYs9L31GC4QtbdWY=; b=ob4L4pRmGz5/c/n4foCuMJ6BM/qNLndRcSt2ucOZC8Gj49j+A+hf5xvWS2kwkBfjSO I+476hwcmtYSUjWornyN1MmkObBc2bEgSmY5ymNMMx1m3XuqpNbsZoWjaYgUzo98QPaO Ysg2zWF0MM0Lyovi9hViZgYZZyJdv4as+hkWfF8/VzrN2Kb+cBlOoQdzWLes8Q8Y9oTD lFclnPd3HwWfYokvLkhvTalwQUeL62X+OO8Uu3QZDICSxtaNJSV+ImHpRM5FumY4p0DS H0yi316dxyP1nJHKdlFdVqmQrZzeJmL0TiF5cTv1S8WfjK84aOAcyZw+g4gGSmdBfN5g QwLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bv25si2356903ejb.462.2021.01.18.05.00.13; Mon, 18 Jan 2021 05:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391698AbhARMgU (ORCPT + 99 others); Mon, 18 Jan 2021 07:36:20 -0500 Received: from mga07.intel.com ([134.134.136.100]:10055 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391503AbhARMaj (ORCPT ); Mon, 18 Jan 2021 07:30:39 -0500 IronPort-SDR: nUwFUPJV6CSSo518YJoIPh6QYXAsuZMMB2c9JMkiVvps0LfDPy9QM6a39QgjQ1KhD1lwDqAPOf 25ZwWjMvfLoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="242866894" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="242866894" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 04:28:53 -0800 IronPort-SDR: 6iH2ILx1Vuk7B7LU89OE6QX3T0bl5uWmnLgdqabGa401cHoG+kpRpyXtCNjDmh0DUPh5ZxHfA4 5T0Cd9pQihGg== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="346860180" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 04:28:48 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1TfK-0027Uk-F1; Mon, 18 Jan 2021 14:29:50 +0200 Date: Mon, 18 Jan 2021 14:29:50 +0200 From: Andy Shevchenko To: Laurent Pinchart Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, andy@kernel.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, lee.jones@linaro.org, hdegoede@redhat.com, mgross@linux.intel.com, robert.moore@intel.com, erik.kaneda@intel.com, sakari.ailus@linux.intel.com, kieran.bingham@ideasonboard.com Subject: Re: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils Message-ID: <20210118122950.GE4077@smile.fi.intel.com> References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-2-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 09:24:10AM +0200, Laurent Pinchart wrote: > On Mon, Jan 18, 2021 at 12:34:22AM +0000, Daniel Scally wrote: ... > > +bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle); > > "lpss" stands for low power subsystem, an Intel device within the PCH > that handles I2C, SPI, UART, ... I think the function should be renamed, > as it's now generic. acpi_dev_has_dep() is a potential candidate, I'm > sure better ones exist. A bit of kerneldoc would also not hurt. Actually a good suggestions. Please apply my tag after addressing above. -- With Best Regards, Andy Shevchenko