Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 16:09:31 +0200
From:   Kari Argillander <kari.argillander@gmail.com>
To:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pali@kernel.org" <pali@kernel.org>,
        "dsterba@suse.cz" <dsterba@suse.cz>,
        "aaptel@suse.com" <aaptel@suse.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "joe@perches.com" <joe@perches.com>,
        "mark@harmstone.com" <mark@harmstone.com>,
        "nborisov@suse.com" <nborisov@suse.com>,
        "linux-ntfs-dev@lists.sourceforge.net" 
        <linux-ntfs-dev@lists.sourceforge.net>,
        "anton@tuxera.com" <anton@tuxera.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "hch@lst.de" <hch@lst.de>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "andy.lavr@gmail.com" <andy.lavr@gmail.com>
Subject: Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block
Message-ID: <20210118140931.e2qdposfez2jsbbr@kari-VirtualBox>
References: <20201231152401.3162425-1-almaz.alexandrovich@paragon-software.com>
 <20201231152401.3162425-3-almaz.alexandrovich@paragon-software.com>
 <20210103195017.fim2msuzj3kup6rq@kari-VirtualBox>
 <750a0cef33f34c0989cacfb0bcd4ac5e@paragon-software.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <750a0cef33f34c0989cacfb0bcd4ac5e@paragon-software.com>
Precedence: bulk

On Mon, Jan 18, 2021 at 09:35:05AM +0000, Konstantin Komarov wrote:
> From: Kari Argillander <kari.argillander@gmail.com>
> Sent: Sunday, January 3, 2021 10:50 PM
> > On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote:
> > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> > 
> > > +int ntfs_create_inode(struct inode *dir, struct dentry *dentry,
> > > +		      const struct cpu_str *uni, umode_t mode, dev_t dev,
> > > +		      const char *symname, u32 size, int excl,
> > > +		      struct ntfs_fnd *fnd, struct inode **new_inode)
> > > +{
> > 
> > > +#ifdef CONFIG_NTFS3_FS_POSIX_ACL
> > 
> > In Kconfig this is NTFS3_POSIX_ACL. This repeat every file.
> > 
> 
> This is OK. You may refer to similar parts of ext4/btrfs sources as a
> reference:
> fs/ext4/Kconfig or fs/btrfs/Kconfig
> 

But in ext4 and btrfs Kconfig specify *_FS_POSIX_ACL. In ntfs3 Kconfig
specify *_POSIX_ACL. So we missing _FS_ in our Kconfig?