Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1610705349-24310-1-git-send-email-abaci-bugfix@linux.alibaba.com> <64a316c8-bc53-69af-8325-2746f6f1827c@broadcom.com>
In-Reply-To: <64a316c8-bc53-69af-8325-2746f6f1827c@broadcom.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 18 Jan 2021 16:29:19 +0100
Message-ID: <CACRpkda9KrKU2PV3qghAqYNPoBtW+pb0K-+8E5BhOcgo9QOuWA@mail.gmail.com>
Subject: Re: [PATCH] drivers/pinctrl/bcm: Simplify bool comparison
To:     Ray Jui <ray.jui@broadcom.com>
Cc:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 15, 2021 at 7:24 PM Ray Jui <ray.jui@broadcom.com> wrote:

> > -             if ((pull_up == false) && (pull_down == false))
> > +             if (!pull_up && !pull_down)
>
> Looks fine as improvement, but I'm curious why there's a warning to
> start with.

There is no semantic difference. This is a purely syntactic warning.

Yours,
Linus Walleij