Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 11:10:20 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Cornelia Huck <cohuck@redhat.com>
CC:     Max Gurtovoy <mgurtovoy@nvidia.com>, <alex.williamson@redhat.com>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <liranl@nvidia.com>, <oren@nvidia.com>, <tzahio@nvidia.com>,
        <leonro@nvidia.com>, <yarong@nvidia.com>, <aviadye@nvidia.com>,
        <shahafs@nvidia.com>, <artemp@nvidia.com>, <kwankhede@nvidia.com>,
        <ACurrid@nvidia.com>, <gmataev@nvidia.com>, <cjia@nvidia.com>
Subject: Re: [PATCH RFC v1 0/3] Introduce vfio-pci-core subsystem
Message-ID: <20210118151020.GJ4147@nvidia.com>
References: <20210117181534.65724-1-mgurtovoy@nvidia.com>
 <20210118143806.036c8dbc.cohuck@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210118143806.036c8dbc.cohuck@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.162.115.133) by BL1PR13CA0057.namprd13.prod.outlook.com (2603:10b6:208:257::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.9 via Frontend Transport; Mon, 18 Jan 2021 15:10:22 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1l1WAe-002y4q-S5; Mon, 18 Jan 2021 11:10:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1610982625; bh=zp2nJWf58scXc0afBue44ww+YYq51czW6B5CBcS/vu0=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date:
         From:To:CC:Subject:Message-ID:References:Content-Type:
         Content-Disposition:In-Reply-To:X-ClientProxiedBy:MIME-Version:
         X-MS-Exchange-MessageSentRepresentingType;
        b=qLLGAgc64qkskmjLvhhreZGI71df9up6Y9Izoko5k5FScv5LVuxBjIU+cGPc7N2HI
         soWCZFnwzCGfSk2G61bPnucg7tqSBgH8/FEyaI2tKbNrxp0pisyZ0wUdUnsjk2nXMN
         y2DSMK+1RMMPEXKcti2NLrOhk11p5ZH6TSGZAz/JFOP5bv1r5Voz6HNISCNIFq2VC5
         2BYhW4dUYgEoW0wly+h5rRk6aQWoNeQJWrC67TMh6/BttzfYP34LuibzBjdchkYASA
         ksDxiboeUjGOCeyh5svXiBYI/kgniMopLEQ2sj5Xno4K1cHcAVaSnbymZiE0hNVsEr
         ygVy2eLpM/vpg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 18, 2021 at 02:38:06PM +0100, Cornelia Huck wrote:

> > These devices will be seen on the Auxiliary bus as:
> > mlx5_core.vfio_pci.2048 -> ../../../devices/pci0000:00/0000:00:02.0/0000:05:00.0/0000:06:00.0/0000:07:00.0/mlx5_core.vfio_pci.2048
> > mlx5_core.vfio_pci.2304 -> ../../../devices/pci0000:00/0000:00:02.0/0000:05:00.0/0000:06:00.0/0000:07:00.1/mlx5_core.vfio_pci.2304
> > 
> > 2048 represents BDF 08:00.0 and 2304 represents BDF 09:00.0 in decimal
> > view. In this manner, the administrator will be able to locate the
> > correct vfio-pci module it should bind the desired BDF to (by finding
> > the pointer to the module according to the Auxiliary driver of that
> > BDF).
> 
> I'm not familiar with that auxiliary framework (it seems to be fairly
> new?); 

Auxillary bus is for connecting two parts of the same driver that
reside in different modules/subystems. Here it is connecting the vfio
part to the core part of mlx5 (running on the PF).

> but can you maybe create an auxiliary device unconditionally and
> contain all hardware-specific things inside a driver for it? Or is
> that not flexible enough?

The goal is to make a vfio device, auxiliary bus is only in the
picture because a VF device under vfio needs to interact with the PF
mlx5_core driver, auxiliary bus provides that connection.

You can say that all the HW specific things are in the mlx5_vfio_pci
driver. It is an unusual driver because it must bind to both the PCI
VF with a pci_driver and to the mlx5_core PF using an
auxiliary_driver. This is needed for the object lifetimes to be
correct.

The PF is providing services to control a full VF which mlx5_vfio_pci
converts into VFIO API.

> >  drivers/vfio/pci/Kconfig            |   22 +-
> >  drivers/vfio/pci/Makefile           |   16 +-
> >  drivers/vfio/pci/mlx5_vfio_pci.c    |  253 +++
> >  drivers/vfio/pci/vfio_pci.c         | 2386 +--------------------------
> >  drivers/vfio/pci/vfio_pci_core.c    | 2311 ++++++++++++++++++++++++++
> 
> Especially regarding this diffstat... 

It is a bit misleading because it doesn't show the rename

Jason