Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including
 SEV-ES support
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     "H. Peter Anvin" <hpa@zytor.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Brijesh Singh <brijesh.singh@amd.com>
References: <20210116002517.548769-1-seanjc@google.com>
 <015821b1-9abc-caed-8af6-c44950bd04f0@amd.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <2d795f19-2ac8-ea74-4365-41ea07f8eeec@redhat.com>
Date:   Mon, 18 Jan 2021 19:03:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <015821b1-9abc-caed-8af6-c44950bd04f0@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 16/01/21 06:40, Tom Lendacky wrote:
> 
>> Introduce a new Kconfig, AMD_SEV_ES_GUEST, to control the inclusion of
>> support for running as an SEV-ES guest.  Pivoting on AMD_MEM_ENCRYPT for
>> guest SEV-ES support is undesirable for host-only kernel builds as
>> AMD_MEM_ENCRYPT is also required to enable KVM/host support for SEV and
>> SEV-ES.
> 
> I believe only KVM_AMD_SEV is required to enable the KVM support to run 
> SEV and SEV-ES guests. The AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT setting is 
> only used to determine whether to enable the KVM SEV/SEV-ES support by 
> default on module load.

Right:

         if (IS_ENABLED(CONFIG_KVM_AMD_SEV) && sev) {
                 sev_hardware_setup();
         } else {
                 sev = false;
                 sev_es = false;
         }

I removed the addition to "config AMD_MEM_ENCRYPT_ from Sean's patch, 
but (despite merging it not once but twice) I don't really like the 
hidden dependency on AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT and thus 
AMD_MEM_ENCRYPT.  Is there any reason to not always enable sev/sev_es by 
default?

Paolo