Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including
 SEV-ES support
To:     Borislav Petkov <bp@alien8.de>
Cc:     Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Tom Lendacky <thomas.lendacky@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>
References: <20210116002517.548769-1-seanjc@google.com>
 <d4deb3ba-5c72-f61c-5040-0571822297c6@redhat.com>
 <20210118202611.GH30090@zn.tnic>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <2262feb0-830e-1e05-d81b-031d54cf6853@redhat.com>
Date:   Mon, 18 Jan 2021 21:30:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210118202611.GH30090@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/01/21 21:26, Borislav Petkov wrote:
> On Mon, Jan 18, 2021 at 06:59:38PM +0100, Paolo Bonzini wrote:
>> On 16/01/21 01:25, Sean Christopherson wrote:
>>>
>>> @@ -1527,12 +1527,14 @@ config AMD_MEM_ENCRYPT
>>>   	select DYNAMIC_PHYSICAL_MASK
>>>   	select ARCH_USE_MEMREMAP_PROT
>>>   	select ARCH_HAS_FORCE_DMA_UNENCRYPTED
>>> -	select INSTRUCTION_DECODER
>>>   	help
>>>   	  Say yes to enable support for the encryption of system memory.
>>>   	  This requires an AMD processor that supports Secure Memory
>>>   	  Encryption (SME).
>>> +	  This also enables support for running as a Secure Encrypted
>>> +	  Virtualization (SEV) guest.
>>> +
>>>   config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
>>>   	bool "Activate AMD Secure Memory Encryption (SME) by default"
>>>   	default y
>>> @@ -1547,6 +1549,15 @@ config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
>>>   	  If set to N, then the encryption of system memory can be
>>>   	  activated with the mem_encrypt=on command line option.
>>> +config AMD_SEV_ES_GUEST
>>> +	bool "AMD Secure Encrypted Virtualization - Encrypted State (SEV-ES) Guest support"
>>> +	depends on AMD_MEM_ENCRYPT
>>> +	select INSTRUCTION_DECODER
>>> +	help
>>> +	  Enable support for running as a Secure Encrypted Virtualization -
>>> +	  Encrypted State (SEV-ES) Guest.  This enables SEV-ES boot protocol
>>> +	  changes, #VC handling, SEV-ES specific hypercalls, etc...
>>> +
>>
>> Queued, thanks.
> 
> Say, Paolo, why are you queuing a patch which goes through tip, if at all?

Right you are, unqueued.  I would have caught the mistake before 
actually crystallizing the hashes, but thanks for noticing!

Sean, please send a v2 that removes the help change for AMD_MEM_ENCRYPT, 
too.

Thanks,

Paolo