Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2259885pxb; Mon, 18 Jan 2021 12:37:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzj5Ro/nG1V72OFZ/hEC70K3Y6+aAdcPZIJvuku79tEHZ45mU3lkTiS/xyf8cSVvezGcdA3 X-Received: by 2002:a17:906:f98f:: with SMTP id li15mr906471ejb.123.1611002279748; Mon, 18 Jan 2021 12:37:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611002279; cv=none; d=google.com; s=arc-20160816; b=ke34sgwvVKEurh/hFyxEqIe+46hI1xUzGCUfXRzM/Kn3X3BTZu6tMsTF7ykFatKI1o lfjkqJ76ukRd2Mz5KqPpOXRBZojdJfid/rO64URpZVKQ9A9wbD0bPdl8JfpQoF2HZcEp Pzr183ajXdTHTX5z0/aAKRIZAPDV5DhJGiLWOXQ5yymwzHqX/2PfY7S26q3yX9JWg5q2 DvOaj66+OMEJebNxwa3h+8jtSnm3HF1S7BxM30eE15J4q9W94Rbj3J/1nxlKo6ysmSxT AOzBK44Ok+sf9sNV13dkRVj9tyBSuaDPgbmKHhPC964IkT4CoBM7vQrfCnVgTythtXdx ULnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=3xeiRxP89GqV4nkQcs1ytqWYC+vgTWlp9fX+035j4yU=; b=kDXpUD/iL9q5GdBa7i2SA5SqCik6YWhA0boLH8OY7E91989N5MrZYY/HjZcohZY7rJ YEXhWPwhqMe1P82D4xDrxb7zI/1nQdWuv7op1EvZLzMDgcwMfWwcvnorTVut3MHO60EE M1yKqNvK3R1LF+2EglQ7oE+pVy+vKemiG30s49jCKc6EyksgdGTQHwFvMNK+7aDtOLwE T0PFvTEjMUX/pCzbbWecBKyIIB6bJk5W81eSWNHdQVo+LNDEjUoJQKM7RmNLxiuHpWQZ RGBpah1Ca0ZcOkU9VCP5j/nTMRGJmy9JXrnHCKGTDE8YwzSozRDOxlUwnr1Bg7OBLct+ 0RaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca8si8212769edb.365.2021.01.18.12.37.36; Mon, 18 Jan 2021 12:37:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388533AbhARUfZ (ORCPT + 99 others); Mon, 18 Jan 2021 15:35:25 -0500 Received: from mga02.intel.com ([134.134.136.20]:11904 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388424AbhARKiI (ORCPT ); Mon, 18 Jan 2021 05:38:08 -0500 IronPort-SDR: yGk6tcRyZRs1Q0B032xLaLWbEgekjpMixndMTbkdbTYlT0mycpLSAhPD9LfgXKyivEpkI28ITi YgmRd1HnUS0Q== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="165875879" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="165875879" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 02:35:52 -0800 IronPort-SDR: X4B8qIGOxOm+Yepnyf4oX6+9r9d4Zwpv/E8Y92Chk7pAiXf5ypFJkqHdeZNq7dRfU3dIh15kFR 1WmqdiMFtrZQ== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="426096392" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 02:35:51 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1Ru1-0020YC-Og; Mon, 18 Jan 2021 12:36:53 +0200 Date: Mon, 18 Jan 2021 12:36:53 +0200 From: Andy Shevchenko To: Daniel Latypov Cc: davidgow@google.com, brendanhiggins@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH v2] lib: add basic KUnit test for lib/math Message-ID: <20210118103653.GA4077@smile.fi.intel.com> References: <20210114182700.1298392-1-dlatypov@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114182700.1298392-1-dlatypov@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 10:27:00AM -0800, Daniel Latypov wrote: > Add basic test coverage for files that don't require any config options: > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignored int_pow.c since it's a simple textbook algorithm.) > > These tests aren't particularly interesting, but they > * provide a place to add tests for any new files in this dir > * are written so adding new test cases to cover edge cases should be easy > lib/math/math_test.c | 197 +++++++++++++++++++++++++++++++++++++++++++ Can it have _kunit instead of _test? -- With Best Regards, Andy Shevchenko