Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115153348.131791-1-trix@redhat.com>
In-Reply-To: <20210115153348.131791-1-trix@redhat.com>
From:   Karol Herbst <kherbst@redhat.com>
Date:   Mon, 18 Jan 2021 11:33:57 +0100
Message-ID: <CACO55tskaWz07cNdvpUE6wQw-7K2qwS8U1sokAeCtAF5naKuSA@mail.gmail.com>
Subject: Re: [Nouveau] [PATCH] tracing: remove definition of DEBUG
To:     Tom Rix <trix@redhat.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@kernel.org>,
        Karol Herbst <karolherbst@gmail.com>,
        Pekka Paalanen <ppaalanen@gmail.com>,
        nouveau <nouveau@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Karol Herbst <kherbst@redhat.com>

On Fri, Jan 15, 2021 at 11:51 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> Defining DEBUG should only be done in development.
> So remove DEBUG.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  kernel/trace/trace_mmiotrace.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
> index 84582bf1ed5f..2c3c31791497 100644
> --- a/kernel/trace/trace_mmiotrace.c
> +++ b/kernel/trace/trace_mmiotrace.c
> @@ -5,8 +5,6 @@
>   * Copyright (C) 2008 Pekka Paalanen <pq@iki.fi>
>   */
>
> -#define DEBUG 1
> -
>  #include <linux/kernel.h>
>  #include <linux/mmiotrace.h>
>  #include <linux/pci.h>
> --
> 2.27.0
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
>