Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2263329pxb; Mon, 18 Jan 2021 12:45:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3s80aTuIi0RBnu1JhIRgYaXnDeaySfw+9cpX4hqkq7xnC9YQqa/Pt1g46ZqZtWl610pWD X-Received: by 2002:a17:906:4bc2:: with SMTP id x2mr936945ejv.4.1611002713010; Mon, 18 Jan 2021 12:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611002713; cv=none; d=google.com; s=arc-20160816; b=yLORfCO8gJEs5m10LpZL7x3XIqj8BTVE+JX3XkZ36+Phm3meVJxEdvwH9y2EDqXnZA BvxuxiLOcsNBSxo5uOcZKkxaowQUDw20Moy2ivIMhHlLll4XubtCiA9CbeOHL8nlxZuz HHSQaDnizvCbpxvwMQLw2XQCpDy/Mb/HCt2ckL+uQfjbqx2+k4h2GBFrv7yW3HKGxe1y ZjueBIRikUPcnJYM0w3HElkBxycb9sgWt1HvBRas/0y7eGljtD2UtqyippchpUaE+huF DeoIK7mQVGhmqKfX6R02F0DyhMovoCJ+d7TAN8OU9xM3RyuCBT8NJA/3NLIq88OJzo+h l4+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=y1IX8cJV13sM534LfX7SrpFO51tpHSn9kjkr0OV2Plw=; b=uKPMcewOrcC2NUZMZt7Ii/1OBZWFdsTtdE/g7ScFwoF1nqLOaIy4kwKEBYHlqQXcT8 9CYVr0JDV7htOkGc6/RDZewPygVTf90vODWQl6gFciUV4LEgq1ZiDM0nP0HPQODkr51x IUR+Sz1ah7CxfwQc1tIUxVmBi0fn0vuWHwsmEQs6+v6u4h6OdwqTwOkHnqGXmAjcqJ7t TVPlN0X/iBNimx/l+khNczKUNS2rObAxb/ubLuJwyOBvg1+gyx6AC8Po38gAbjri+qk+ w0C1b6xpAsJS7B9hB1dXg1aYhKOoNgYVGuXEh0Lnk5125GRzsFOAW4xgCVdr9gHM6dUJ gRXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s26si988748ejv.241.2021.01.18.12.44.49; Mon, 18 Jan 2021 12:45:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394417AbhARUkp (ORCPT + 99 others); Mon, 18 Jan 2021 15:40:45 -0500 Received: from mga02.intel.com ([134.134.136.20]:11758 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388123AbhARKeq (ORCPT ); Mon, 18 Jan 2021 05:34:46 -0500 IronPort-SDR: lWHaNGI0fEk8EESmn4AnKcEc9XN7qMxX+R6+LFy+0gHb0j2q+NFzwRKLUmD0YMug/c8cExj4zV CQcl7+nFVA3A== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="165875674" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="165875674" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 02:32:54 -0800 IronPort-SDR: XNsg8r+7X51sKJdWzEP/HXibKgWg2YheMWmfaX+Ki6PgAh528fj6VYxgm++ot2Sm74MRpYYjrA sgoMmGzjibXg== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="466322458" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 02:32:53 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1Rr9-0020Mn-Na; Mon, 18 Jan 2021 12:33:55 +0200 Date: Mon, 18 Jan 2021 12:33:55 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: Daniel Scally , gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com Subject: Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols Message-ID: <20210118103355.GZ4077@smile.fi.intel.com> References: <20210113000209.322218-1-djrscally@gmail.com> <20210118094945.GX11878@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118094945.GX11878@paasikivi.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote: > On Wed, Jan 13, 2021 at 12:02:09AM +0000, Daniel Scally wrote: > > + * to_software_node() - Fetch software node associated with a firmware node handle > > Please wrap lines over 80 (unless there's a reason to keep them longer). Does kernel-doc behave good when you wrap the function summary line? My impression that summary should be one line. -- With Best Regards, Andy Shevchenko