Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2291118pxb; Mon, 18 Jan 2021 13:40:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrNrwSTScUyxXcF/aoxmDXjgeV64wbKIA4Q/kWbRjbp+YoWGGS4+VsO0zIO2b7ZVysEkjn X-Received: by 2002:aa7:cdc3:: with SMTP id h3mr1065287edw.52.1611006037838; Mon, 18 Jan 2021 13:40:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611006037; cv=none; d=google.com; s=arc-20160816; b=p1mZbGyM6ZAdy9I/WXQKOFV5lIGUA8bKm9nWwNT+sLuw+iEca44sarXq5r1OjTkkjD 453zoJFftKJ3E+4l/P4Yk2oIvHno1uiciWPSjOUwRgCgsJTVK4Ly7Ia+pJsnD8hBeilI yLhGadl/xiG3wp7loFuSHhLQv2L6NKgznUl4q28/CKt4DzFRWFZuVQ2eWKGIayVcCpIA xNjGT+oqUpuOLnFuOgbGPcfl3QuNIHI2biayvSAo6ar2Ca5b+YTPewLNBuMNS7lUBGtc O7I6xwDcmqVQ3Vu0B6jUkn+2ZB4NKryxZ3aEGcZ/4ZTu85WzPwap1Z1hUAD5asi2ScVL ZAhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=FWfMRlECo3Ha5GQnu5lC6Yxozk4PGv9x5wy8+9maptc=; b=AxnElTXXHz+5MPlQz+HhE2xmQe6U2RM9pFIwS8YLo1JQRDjHyhn91oSqldAB9IYe3M cOtjjwmNllpOhf9m3ku4MOekmC5zf1em+wR6CITnCAZzopktH6euH1BJTBLkW8f25umb 5TzQkYhS4VA89u68uvXQ7V66RnaKsa5yicdIjWXZc0w/HCrtRpIfrHWsQ4j4oTNbxZKU okx/20M07aXWebL2wj4G6cpR3UOP5m7GJ3cbjFdbw7cuOsudUNTgox/bZJ0mAsYrxGTj cF6HAt43tz0PGJbWWfaBm9dVKWWwQ60RpRi7xkpZqe4ZjefXrwZvIgB/JllDJExLPOOb 3GUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l1lR1HZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f13si3983857edx.272.2021.01.18.13.40.11; Mon, 18 Jan 2021 13:40:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l1lR1HZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394738AbhARVfm (ORCPT + 99 others); Mon, 18 Jan 2021 16:35:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:39400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389442AbhARKDc (ORCPT ); Mon, 18 Jan 2021 05:03:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C64EA221FF; Mon, 18 Jan 2021 10:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610964160; bh=lKbRkVLl0TvJXkgmMwDlKtpVfY+ThcC89YEz8gZ02EQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=l1lR1HZLrBeCwvgvgWQNUduCUQIJLeM2ttXJ6Kc3HOYwciiNY94SJkKZDIrJ6uFP8 DFWkoZ8iLcEMLMSCKz5Bz1HHoR+cTC6AfLlvYjNHbeqrcGBK2Ef+hp2MQsmDMvO5vs R7LU00JFedM8GKjO3YhTvwQukwLfkt3SCZxPBHZY79VsdtePMrxTjUqTDFiDW9zap7 apebJLctG2glWzt8njpajvPz/MgoF1W49iwLdmTer7VRSIT0WK+uHeO3twRM9UU/R5 E3hulgHkLM1joW/rVePfHGYIOXy9V9Bt3J6B94oPULC0KCExQVrhuuIrkonJwFa/fe oANZQzQQI2unA== Date: Mon, 18 Jan 2021 11:02:37 +0100 (CET) From: Jiri Kosina To: =?ISO-8859-15?Q?Filipe_La=EDns?= cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature In-Reply-To: Message-ID: References: <20210104182937.1472673-1-lains@archlinux.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jan 2021, Filipe Laíns wrote: > Yeah :head_scratch: > There is a header comment at the start of each feature section, which I think > does a good job pointing this out. IMO the problem with the naming is more for > people who see its usage in other parts of the code, but I guess that is C for > you right? Names don't scale well with code quantity :P Alright ... thug life :) Let's just keep it the way it is. > > > > Could you please use standard kernel commenting style here? > > > > > > Oops, sorry. Will do :) I have adjusted the wrong comment and applied. Thanks, -- Jiri Kosina SUSE Labs