Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 15:02:42 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     robh@kernel.org, festevam@gmail.com, kernel@pengutronix.de,
        linux-imx@nxp.com, catalin.marinas@arm.com, will@kernel.org,
        krzk@kernel.org, kernel@puri.sm, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] arm64: dts: imx8mq-librem5: enable the LCD panel
Message-ID: <20210118070241.GL28365@dragon>
References: <20210112095151.4995-1-martin.kepplinger@puri.sm>
 <20210112095151.4995-7-martin.kepplinger@puri.sm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210112095151.4995-7-martin.kepplinger@puri.sm>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Jan 12, 2021 at 10:51:48AM +0100, Martin Kepplinger wrote:
> This enables the Librem5's ft8006p based LCD panel driven by the
> imx8mq's Northwest Logic DSI IP core and mxsfb display controller.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  .../boot/dts/freescale/imx8mq-librem5.dtsi    | 51 ++++++++++++++++++-
>  1 file changed, 49 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index f77b51d3c132..440931f81c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -310,6 +310,17 @@
>  		>;
>  	};
>  
> +	pinctrl_dsirst: dsirstgrp {
> +		fsl,pins = <
> +			/* DSI_RST */
> +			MX8MQ_IOMUXC_ENET_RD3_GPIO1_IO29	0x83
> +			/* DSI_TE */
> +			MX8MQ_IOMUXC_ENET_RD2_GPIO1_IO28	0x83
> +			/* TP_RST */
> +			MX8MQ_IOMUXC_ENET_RX_CTL_GPIO1_IO24	0x83
> +		>;
> +	};
> +
>  	pinctrl_ecspi1: ecspigrp {
>  		fsl,pins = <
>  			MX8MQ_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI	0x83
> @@ -817,12 +828,12 @@
>  		compatible = "tps65132";
>  		reg = <0x3e>;
>  
> -		outp {
> +		reg_lcd_avdd: outp {
>  			regulator-name = "LCD_AVDD";
>  			vin-supply = <&reg_lcd_3v4>;
>  		};
>  
> -		outn {
> +		reg_lcd_avee: outn {
>  			regulator-name = "LCD_AVEE";
>  			vin-supply = <&reg_lcd_3v4>;
>  		};
> @@ -947,6 +958,42 @@
>  	};
>  };
>  
> +&lcdif {
> +	status = "okay";
> +};
> +
> +&mipi_dsi {
> +	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;

Please end property list with `status`.

> +
> +	lcd_panel: panel@0 {
> +		compatible = "mantix,mlaf057we51-x";
> +		reg = <0>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_dsirst>;
> +		avdd-supply = <&reg_lcd_avdd>;
> +		avee-supply = <&reg_lcd_avee>;
> +		vddi-supply = <&reg_lcd_1v8>;
> +		backlight = <&backlight_dsi>;
> +		reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;

Have a newline between properties and child node.

> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&mipi_dsi_out>;
> +			};
> +		};
> +	};
> +
> +	ports {
> +		port@1 {
> +			reg = <1>;

Ditto

Shawn

> +			mipi_dsi_out: endpoint {
> +				remote-endpoint = <&panel_in>;
> +			};
> +		};
> +	};
> +};
> +
>  &pgc_gpu {
>  	power-supply = <&buck3_reg>;
>  };
> -- 
> 2.20.1
>