Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 Jan 2021 09:12:37 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Bruno Thomsen <bruno.thomsen@gmail.com>,
        devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
        linux-kernel@vger.kernel.org, Bruno Thomsen <bth@kamstrup.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
Message-ID: <20210118081237.mgcxyob42hv5hdnp@pengutronix.de>
References: <20210111151537.12530-1-bruno.thomsen@gmail.com>
 <20210118063252.GJ28365@dragon>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tehix5zhhrl3q6mw"
Content-Disposition: inline
In-Reply-To: <20210118063252.GJ28365@dragon>
Precedence: bulk


--tehix5zhhrl3q6mw
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 18, 2021 at 02:32:53PM +0800, Shawn Guo wrote:
> On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> > RTC pcf2127 device driver has changed default behaviour of the watchdog
> > feature in v5.11-rc1. Now you need to explicitly enable it with a
> > device tree property, "reset-source", when used in the board design.
>=20
> It sound that the existing DTBs are broken by this default behaviour
> change?

I didn't do a representative research, but I expect that there are only
very few machines that have a working watchdog setup using the pcf2127.
All other machines were surprised by commit

	0e735eaae165 ("rtc: pcf2127: add watchdog feature support")

because they suddenly had a non-functional watchdog device. The
alternative would be to "fix" the device trees of all these machines to
restore pre-v5.4-rc1 behaviour. This is IMHO worse.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--tehix5zhhrl3q6mw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmAFQukACgkQwfwUeK3K
7Am55gf+Ovx9hJP0bLpt4Sc5iOSaKU/x3Jo40vV0amY/uvZkHTPJEbRb5R7sweFC
mXjK0WkkLhLKJZJHSmiz2AC4iu3Hf/Q96IjQ8XxmsSHdszv4Kit3ALwFSRNB3b5q
2xzq1t1MNYchIH2hHoBRx/RZR0t6+0JwJhHfldsC1kce8mFp6upg3bsNlesM1HmT
hWARzMC1ev4JiRj9NkVQLy0NZWOrgZD6Tr/PARigv25vKA6i7xUdxwlekJQkFmrf
8Scvj8/yFfPczgFhOwMTIMqai0cJVvMEbpVq/wqftAh+OLqA3z0uPKaUQ4toXto0
SPAEZZUqJ5pZhsEh7yPoZhjrzElWaw==
=bunu
-----END PGP SIGNATURE-----

--tehix5zhhrl3q6mw--