Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2466296pxb; Mon, 18 Jan 2021 20:08:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLG5ntEiYgNU4OrQFgfSQ9dxZUCFcQC6nnVpbjEEG9k0cokgBpNwdsa8IartrJV1t0kW0a X-Received: by 2002:a17:906:f919:: with SMTP id lc25mr1783703ejb.323.1611029331525; Mon, 18 Jan 2021 20:08:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611029331; cv=none; d=google.com; s=arc-20160816; b=GUtR7xCHEnlbtKKNZDhYNm/RH6PUv5DnCa/MDDdMY0CZfroMh1upZIXiS4hDCnM2jh nWGDxQezREXcZW1Q20jbjC61xM7P0MkJqbXr1bU1suPAq4FzJ8u4GM7LRMbqgGhOtIyY L9FqjvpuKxrl7KtR232OX7iQ3rvtA+8Kz2miJ888vH6g0RycVPj1WNeL+Je47b2aXPtw yTPP01fg+3MUwCM3rQctW9Zlnusa1cE1dH5GTBfFzTk9lmZz5btMRvJf2nlLRLfECgU1 Y5gkd0Se6bwhvRuShrD31Og4ETpgrRH0514AG/DAiQPtKbSThsf4gpEDAytWV9sksVoh kYoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6p6b2bX0U301f0BdWvTVofVddxEPuQgwvPGN6I0n6WI=; b=YgaXNZRRd8VkpzZJK3vOlxRuRwYBGlMvNKcKA1iGMhjlr2DVnl97RctkR9HhAhLY62 9ki9/ZvIg/ytLihQ2qRPdq80lyUFI/4iatNo3dBM2/QyBqN5UIvXdFsfNl6DClwWOwuX /SG2q29vpOhsEBOKXhpwtKLQpu56m7DeZ3y+HHDakEW3CUfACERjKfLI8v3fJPzPgc3E D2dZUPLa+l5lRYJZFwNRbGM1Jvli1ObSNVX4/D8WvTgkQ9QpLenS5lLWMtbok8H4wIdY LdgSWh8aG8wgzRA5PHxGBOJlS1rm75K7flzYMt17G3xfV9k+hKfpHOiTqfctKclna9hi y72w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/y1YPLs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si8412990ejj.549.2021.01.18.20.08.22; Mon, 18 Jan 2021 20:08:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/y1YPLs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404002AbhARMGR (ORCPT + 99 others); Mon, 18 Jan 2021 07:06:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:44774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403874AbhARMEn (ORCPT ); Mon, 18 Jan 2021 07:04:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E4AD224B8; Mon, 18 Jan 2021 12:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610971442; bh=5JIZNpOAuXjudU6ZQ7N4iBY+T/rnQaQAjKMQnYWoePw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/y1YPLsE9UFBFBA7q92Oa50xV98nkfD56zidQK28kcnH9LdVVPmjGH7MOCWLCa5W GbNRs7ZtZO4+y+IXTF4AfX5eJxBUBu0ZjvQwHNCnXEQYsR6LmI8IVpx/NHMOuQxk9f yGlJy7Hy7utlv5oVu61EKnEyr1Jb7RMYIyEHZ3BMfH0WZqVH8CoKXnskpetpWyV6XM +Vk8g3/n0HlMRhpmb0Rmz+KxRkLZ7wtdq9aEh/GMBMyls78bpL8Cy08jLabipCsO5o HauiH6xMzlPMYMtlXYsvj48WrZ8n5c/Lr9k9Zu1imT3jFjOn8EXjpLtHGJdq3CvSay sUWaLp7icxyCQ== Date: Mon, 18 Jan 2021 12:03:25 +0000 From: Mark Brown To: Perry Yuan Cc: Perry Yuan , oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com, hdegoede@redhat.com, mgross@linux.intel.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Mario.Limonciello@dell.com Subject: Re: [PATCH v3 3/3] ASoC: rt715:add micmute led state control supports Message-ID: <20210118120325.GB4455@sirena.org.uk> References: <20210112171814.5404-1-Perry_Yuan@Dell.com> <20210112175406.GF4646@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LpQ9ahxlCli8rRTG" Content-Disposition: inline In-Reply-To: X-Cookie: Huh? User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LpQ9ahxlCli8rRTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 16, 2021 at 11:50:31PM +0800, Perry Yuan wrote: > On 2021/1/13 1:54, Mark Brown wrote: > > > + bool micmute_led; > > What is this for, it never seems to be read except for in the function > > where it's set? > Do you mean i can use a local micmute_led var in the function? Yes. --LpQ9ahxlCli8rRTG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAFeQwACgkQJNaLcl1U h9Bi/gf/a1axKJapuFhHFDtl+4V48j7+sPO2o2ca2rzuf5frVz4W4s27sxUvhgr2 t0CPGS0wrR3P15AlEGaMhlBvZbv8KZUA8FAGI3F98fgcxzwWOaWZmDUb/tLrnr3X QQVcX8sCWqz64o/WyBIEqSvKwxkDIgK19RjCHC64Q+JQz5hpPLkdO7uTAbqslLqD AMHP9m5rXkt4p395mENABsxV/fN0i3NESe4sbBR3J4iblIMQ1OTC8Q4/0gmG/mYz 5wy5KjCfT8v4QPMcbp8LjDsg4M0hs2+LdxA2DijSlQyIGgOuhzjB92WcA9Yprfog loUeGuAuZ+Yx88zu3XVDEUmVfcqjxA== =0TFr -----END PGP SIGNATURE----- --LpQ9ahxlCli8rRTG--