Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2475068pxb; Mon, 18 Jan 2021 20:27:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZBqR3xX+MhXplLeFwnvKVb5kc5FLKoFIpvGPEwZdwoJQ7CxyBJ1Y0Is1l1sXpcFDAzPaZ X-Received: by 2002:aa7:ccc6:: with SMTP id y6mr1900086edt.226.1611030462842; Mon, 18 Jan 2021 20:27:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611030462; cv=none; d=google.com; s=arc-20160816; b=SUWtvwcZtLwx58gfuTeJhVTO6VKc/S8q089X4Bu5nu3ZfcXYPTISekJEdCUdLpKSbU nqNrN+1TAzpiUoKaFJRs17DvJ0/MkSf1VzgMSK9ORosRHbd4c2CjlkkRnwKZ5hOozvw5 KLVlweTtU34S57GKOLTqieFrrWf1rR76b+9ppjul31rexNxdDPspOVkpXizxysoP9g9U gtgvc1m7aB1XbeJsd5T5u6CaxSukoWMYHcdCUBraygEYhp2f43nhVaueNGSJzesxDGYm YbPI6kwqx5q9ujS0hMhomvCZaTIF9oNsiyLpZrtP5xMvOMDgQDCoGTr+fC0K/9/lFwY3 XLOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=xJHafc6uFa48L9QuBupo450qlIciepKYlhyLEgBViqs=; b=Z2S3SioMRq5+gJw4RZfLV0sEaVSfPOVTlKZ7ENzinQyWDLUiSHyZskRKm2L2oGVN2K btLCKSc3jHxHEtI4Hh15piyy5Op8w6kFUzaHVpxFb3WesCi8iv9HVA+7veKN+1fpPpVL ljUpgMGWgBR7czX8FOxrYXyeu4V8QPDqbYi7erLjYtNiqmQXKcdlaS89UICpM3KfqrhP lVWeuvMXlcg7vPz3b7W/pCNcLD7yN7fShe0p8eXM5hhGn9IGS0+QMfkxQPiq643995QF ts0Sllj27VXeONwopjDSbJxZ911ksMKhoMzoTvjRqqQVu+Jpu023fSQXQzRmzZn8D9Pp OERA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si42352edv.277.2021.01.18.20.27.19; Mon, 18 Jan 2021 20:27:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404689AbhARNkb (ORCPT + 99 others); Mon, 18 Jan 2021 08:40:31 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2365 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404641AbhARNjt (ORCPT ); Mon, 18 Jan 2021 08:39:49 -0500 Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DKCRW1pPDz67dFQ; Mon, 18 Jan 2021 21:33:43 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 18 Jan 2021 14:39:07 +0100 Received: from localhost (10.47.75.177) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 18 Jan 2021 13:39:06 +0000 Date: Mon, 18 Jan 2021 13:38:26 +0000 From: Jonathan Cameron To: Bartosz Golaszewski CC: Jonathan Cameron , Lars-Peter Clausen , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Anand Ashok Dumbre" , Bartosz Golaszewski , Michal Simek , "Peter Meerwald-Stadler" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres Message-ID: <20210118133826.00004ba6@Huawei.com> In-Reply-To: References: <20201130142759.28216-1-brgl@bgdev.pl> <20201130202110.62e7f989@archlinux> <20201213120442.3f98814a@archlinux> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.75.177] X-ClientProxiedBy: lhreml736-chm.china.huawei.com (10.201.108.87) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jan 2021 10:09:56 +0100 Bartosz Golaszewski wrote: > On Sun, Dec 13, 2020 at 1:04 PM Jonathan Cameron wrote: > > > > On Fri, 11 Dec 2020 12:15:15 +0000 > > Anand Ashok Dumbre wrote: > > > > > > -----Original Message----- > > > > From: Jonathan Cameron > > > > Sent: Monday 30 November 2020 8:21 PM > > > > To: Bartosz Golaszewski > > > > Cc: Lars-Peter Clausen ; Peter Meerwald-Stadler > > > > ; Michal Simek ; linux- > > > > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > > > kernel@vger.kernel.org; Bartosz Golaszewski > > > > ; Anand Ashok Dumbre > > > > > > > > Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres > > > > > > > > On Mon, 30 Nov 2020 15:27:56 +0100 > > > > Bartosz Golaszewski wrote: > > > > > > > > > From: Bartosz Golaszewski > > > > > > > > > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: > > > > > use devm_krealloc()"). I noticed we can use even more devres helpers > > > > > and entirely drop the remove() callback. > > > > > > > > > > v1 -> v2: > > > > > - squash three patches adding more devres calls into one for easier > > > > > review > > > > > - don't insist on the 80 characters limit > > > > > - add a new helper: devm_krealloc_array() and use it > > > > > > > > > > v2 -> v3: > > > > > - drop the devm_krealloc_array() helper > > > > > > > > > > Bartosz Golaszewski (3): > > > > > iio: adc: xilinx: use helper variable for &pdev->dev > > > > > iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() > > > > > iio: adc: xilinx: use more devres helpers and remove remove() > > > > > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 157 > > > > > ++++++++++++++--------------- > > > > > 1 file changed, 74 insertions(+), 83 deletions(-) > > > > > > > > > > > > > Series looks good to me but would like to leave it a little longer to let others > > > > take a look at it. That will probably mean it falls into next cycle now. > > > > > > > > +CC Anand who is looking at another series touching this driver and > > > > +might > > > > give this one a spin as well. > > > > > > > > Thanks, > > > > > > > > Jonathan > > > > > > Hi Jonathan, Bartosz, > > > > > > I have tested and reviewed the patch and everything looks good. > > > I have another patch series on the same files that might cause conflicts. > > > > > > Reviewed-by: Anand Ashok Dumbre > > > Tested-by: Anand Ashok Dumbre > > Thanks, > > > > Applied to the togreg branch of iio.git and pushed out as testing for > > the autobuilders to play with it. > > > > There was a small amount of fuzz. > > > > Thanks, > > > > Jonathan > > > > Hi Jonathan, > > I still don't see these patches in next - is any action required of me > to get this in for the next release? Nope. I still haven't gotten round to asking for the iio tree itself to be pulled into next, and I've been a bit busy so haven't yet sent a pull request to Greg KH this cycle. I'll get the second sorted, probably later this week. J > > Bartosz > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel