Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2496238pxb; Mon, 18 Jan 2021 21:11:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJz29CWMNQvfz50Crvf1FkW+XW1delPwNDWe4OCOGTjIuRnIDYF+dEOKJHqh4yDXK5BxDKL+ X-Received: by 2002:a17:906:a2da:: with SMTP id by26mr1883892ejb.531.1611033109552; Mon, 18 Jan 2021 21:11:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611033109; cv=none; d=google.com; s=arc-20160816; b=ZlOEJAc2vqSn7Nuwef1zGC2m8SqLkMNzbPikpwsg+Yh6KQ8WtsYcE4J/MFk2QmPC30 LJOvDiZEwFD12ebl/xYxt/7jBjQJALsdScoWTsfFsZ2blXA7XClCswltYObvrThnAPoO +jLMrryx1dwmXk7c3HSaXQ1ItVKfm+QlhTyzRPZBrSKs67Z4ZEfuTWGGaZd3fl/s8lCC xmBZ5FBa8Q5bXB/AfoTLhNjPde3vV654fkmumAH+bxAZPusFjGCUtMMCdIYjGe05Ge+0 eMHEuPN9i3tfuI54p/Dvg3N66NRJj8aO8GJWcTFmykLa+BzzNYkxoERGktzi3xYyMqy/ IfJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=csxJ+kKfOHvSmWehXaT4nqOQ0sXQwmYUqvongsXK0Mw=; b=uDUrTqjdB7pSZMFJNAQuZgVSVIbS7aSEJFLt8Y1OXV5mtU3c7MRJ1Fqhk3n/U+OjAJ ebikWA+/hXL8WAeu9LxRqlvPC8zuztdNcPK7xXsmFifBzTG5Ip7q8fvuHOV8XGD0OFEI 4rq80agSI1d+2vpsMe0oIs12A9doC+/q8iI1OnJlexwZzwGyqRDyuxvHaBvzjE8e8uxp TJOjqrJ0px8NZOiEQcQXYZqxoDdz02ANfZa1ivjpzqR2NpXjygbKakKrlsc0oanbDvfD QunwCtl1QznfeHW23AUuu4HLM+2TNNSG5dZNqSHIRXAM/ipIK2XJ4QGLxr0aQA7SP5TU xK6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="kA8Vvw/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t16si7005663ejj.217.2021.01.18.21.11.14; Mon, 18 Jan 2021 21:11:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="kA8Vvw/1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437114AbhARTh7 (ORCPT + 99 others); Mon, 18 Jan 2021 14:37:59 -0500 Received: from mail.skyhub.de ([5.9.137.197]:41920 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388748AbhARTcC (ORCPT ); Mon, 18 Jan 2021 14:32:02 -0500 Received: from zn.tnic (p200300ec2f069f001e13c6b7481d9a7b.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:9f00:1e13:c6b7:481d:9a7b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6BED21EC04F0; Mon, 18 Jan 2021 20:31:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1610998279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=csxJ+kKfOHvSmWehXaT4nqOQ0sXQwmYUqvongsXK0Mw=; b=kA8Vvw/14/dFp9iV53pBm0bdIOX5XqJj5N2yz9wnuB52cPI8Z/eT+z/V92DNiDK8fqKb7B 9gOCN5h47+G16ZToyBYMLNgXHEgHTxckqaHyFbMlvWATsYzSlITAupnsAnuF9g54SHnwDX 5rL8DjJ5zbDIGysOvYei0uqj7tCv/jI= Date: Mon, 18 Jan 2021 20:31:12 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Smita.KoralahalliChannabasappa@amd.com, wgh@torlan.ru Subject: Re: [PATCH] EDAC/AMD64: Update scrub register addresses for newer models Message-ID: <20210118193112.GF30090@zn.tnic> References: <20210116143353.7576-1-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210116143353.7576-1-Yazen.Ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 16, 2021 at 02:33:53PM +0000, Yazen Ghannam wrote: > +static struct { > + u32 base, limit; > +} f17h_scrub_regs = {F17H_M30H_SCR_BASE_ADDR, F17H_M30H_SCR_LIMIT_ADDR}; Why not make this part of struct amd64_umc so that you can access them through pvt->umc? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette