Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2499924pxb;
        Mon, 18 Jan 2021 21:18:12 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzg8MkYh6feuMOkNv9XjwmJyGfv+xx66/cQW71Cus5+COo8300Nu0GtjadCFBELADxNFnHW
X-Received: by 2002:a17:906:194b:: with SMTP id b11mr1910624eje.541.1611033492407;
        Mon, 18 Jan 2021 21:18:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1611033492; cv=none;
        d=google.com; s=arc-20160816;
        b=ilsp+74TAxaoLi72JWhSm6rSWjwPKe3GrVdVufVvxCuRFRP6GdFeojUMwhQVWpfSpx
         KjZAafp9Bl+NWqz+0tIqkyUEvCjXBkCVwCFgWscSH1mrIrY4AZc6qjgP3vunrNQwPXCi
         fG/D2dpJCeVqoiIb0HLBD753nDTDwGDOQr2uoMprjRZKFBqR8E28DpJYcOGDa/qPBJsw
         vTeD7KzosyX0U4NvpA5NJEvXMBC8M5b8Vnqnu+uVCKeINgfVwEEJ6/ElkMswW+5iuw3+
         isi4B3Gk0u62PIIoYXPV48cNswGWgqWvvvZOcFOy/MhL5loXDsfep7L9yljZ/X8s0r/A
         i1xA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:user-agent:in-reply-to
         :content-transfer-encoding:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=hBDtQFyBlKJXIsW/egiLl0IA6V2Hx4RRaCTuyKQG5o8=;
        b=M7D1sKascQS2uCJyKjdAAjOjn6Xi0XgrKpBJTozVwNdBf2VZznd6bet++vaND06s0W
         ZAQukqFdsA3QBFMViW+JoCCihs+iWMWdoazT9uqvhTMTfZUM/ZO3zTDgAkWwxsruKgBZ
         DS3mSfgzwBsYVxbcven+md5BexJvBvNgeceBOnos/8BJKtCh7XIS0fYZUZbANRA+8RWM
         fVFbC4czaNbfTi+PUmcaYpRdGIsT5h4Flvjtc1e4jTozGPcw91CQkRCXMdYiAmK74xmT
         xBAVOEC/B2ltlSfGkdmvSAiZ0v4l58g9uiqUaB29GZdqPZBbQLnJQBsXc+NcLz801yit
         lPfg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=UGpuMd4G;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a16si5690601ejt.459.2021.01.18.21.17.31;
        Mon, 18 Jan 2021 21:18:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=UGpuMd4G;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389005AbhARUbK (ORCPT <rfc822;lkml.akiyano@gmail.com>
        + 99 others); Mon, 18 Jan 2021 15:31:10 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:9875 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388982AbhARKkM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Jan 2021 05:40:12 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B600565550000>; Mon, 18 Jan 2021 02:39:17 -0800
Received: from mtl-vdi-166.wap.labs.mlnx (172.20.145.6) by
 HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id
 15.0.1473.3; Mon, 18 Jan 2021 10:39:12 +0000
Date:   Mon, 18 Jan 2021 12:39:09 +0200
From:   Eli Cohen <elic@nvidia.com>
To:     Thomas Zimmermann <tzimmermann@suse.de>
CC:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <daniel.vetter@ffwll.ch>, <sam@ravnborg.org>,
        <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        <virtualization@lists.linux-foundation.org>
Subject: Re: Change eats memory on my server
Message-ID: <20210118103909.GA45040@mtl-vdi-166.wap.labs.mlnx>
References: <20210114151529.GA79120@mtl-vdi-166.wap.labs.mlnx>
 <23cf7712-1daf-23b8-b596-792c9586d6b4@suse.de>
 <20210117050837.GA225992@mtl-vdi-166.wap.labs.mlnx>
 <83f74a11-b3c0-db2e-8301-4292d60d803b@amd.com>
 <2ea2630b-8782-c662-91fe-683d8b5d6c99@suse.de>
 <20210118091302.GB40909@mtl-vdi-166.wap.labs.mlnx>
 <052812fd-10ce-abf4-d12a-91d4fd66ed54@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <052812fd-10ce-abf4-d12a-91d4fd66ed54@suse.de>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1610966357; bh=hBDtQFyBlKJXIsW/egiLl0IA6V2Hx4RRaCTuyKQG5o8=;
        h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:
         Content-Type:Content-Disposition:Content-Transfer-Encoding:
         In-Reply-To:User-Agent:X-Originating-IP:X-ClientProxiedBy;
        b=UGpuMd4GMtUQMeptbVKeyZy+ylDCkUFgkGvl0O+QmFLFHvQKIMwBJkg9lI7/7p+r1
         rBISSDlJ+SW6+C9Lj1lB2iFGsBpsmc/gux8FUIlo9kof6wHXFMABHhDQ7cb92tMkcl
         Clispq+IEL00sZN4oQvcSzq+AbE2LEZAoDoNGX5vC8iv99gpH8kJ7BFWKWwKxc2h9Y
         P9Tg2L3Ut4G/l+97j/jINCZhyHkXse7DdbyAJY+Pud7uTF1YY3C5tuflryGAGyOnQP
         eW/JwgIk1BmkCd2xzNFwkC371sNjK3FbEl7o7YmptgEahdiougFzkq7Y2GpbM+mm7L
         zxkAMDZE7aOUg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 18, 2021 at 10:30:56AM +0100, Thomas Zimmermann wrote:
> Hi
>=20
> Am 18.01.21 um 10:13 schrieb Eli Cohen:
> > On Mon, Jan 18, 2021 at 08:54:07AM +0100, Thomas Zimmermann wrote:
> > > Hi
> > >=20
> > > Am 18.01.21 um 08:43 schrieb Christian K=F6nig:
> > > > Hi Eli,
> > > >=20
> > > > have you already tried using kmemleak?
> > > >=20
> > > > This sounds like a leak of memory allocated using kmalloc(), so kme=
mleak
> > > > should be able to catch it.
> > >=20
> > > I have an idea what happens here. When the refcount is 0 in kmap, a n=
ew page
> > > mapping for the BO is being established. But VRAM helpers unmap the p=
revious
> > > pages only on BO moves or frees; not in kunmap. So the old mapping mi=
ght
> > > still be around. I'll send out a test patch later today.
> > >=20
> >=20
> > Great! Looking forward to test it.
>=20
> Here's the patch against the latest DRM tree. v5.11-rc3 should work as we=
ll.
>=20
> I was able to reproduce the memory leak locally and found that the patch
> fixes it. Please give it a try.
>=20

Thomas, thanks for looking into it. My first impression is that the
patch indeed fixes the leak.

I will report again later today.

> Best regards
> Thomas
>=20
> >=20
> > > Best regards
> > > Thomas
> > >=20
> > > >=20
> > > > Regards,
> > > > Christian.
> > > >=20
> > > > Am 17.01.21 um 06:08 schrieb Eli Cohen:
> > > > > On Fri, Jan 15, 2021 at 10:03:50AM +0100, Thomas Zimmermann wrote=
:
> > > > > > Could you please double-check that 3fb91f56aea4 ("drm/udl: Retr=
ieve USB
> > > > > > device from struct drm_device.dev") works correctly
> > > > > Checked again, it does not seem to leak.
> > > > >=20
> > > > > > and that 823efa922102
> > > > > > ("drm/cma-helper: Remove empty drm_gem_cma_prime_vunmap()") is =
broken?
> > > > > >=20
> > > > > Yes, this one leaks, as does the one preceding it:
> > > > >=20
> > > > > 1086db71a1db ("drm/vram-helper: Remove invariant parameters from
> > > > > internal kmap function")
> > > > > > For one of the broken commits, could you please send us the out=
put of
> > > > > >=20
> > > > > >  =A0=A0 dmesg | grep -i drm
> > > > > >=20
> > > > > > after most of the memory got leaked?
> > > > > >=20
> > > > > I ran the following script in the shell:
> > > > >=20
> > > > > while true; do cat /proc/meminfo | grep MemFree:; sleep 5; done
> > > > >=20
> > > > > and this is what I saw before I got disconnected from the shell:
> > > > >=20
> > > > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 148208 kB
> > > > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 148304 kB
> > > > > MemFree:=A0=A0=A0=A0=A0=A0=A0=A0=A0 146660 kB
> > > > > Connection to nps-server-24 closed by remote host.
> > > > > Connection to nps-server-24 closed.
> > > > >=20
> > > > >=20
> > > > > I also mointored the output of dmesg | grep -i drm
> > > > > The last output I was able to save on disk is this:
> > > > >=20
> > > > > [=A0=A0 46.140720] ast 0000:03:00.0: [drm] Using P2A bridge for c=
onfiguration
> > > > > [=A0=A0 46.140737] ast 0000:03:00.0: [drm] AST 2500 detected
> > > > > [=A0=A0 46.140754] ast 0000:03:00.0: [drm] Analog VGA only
> > > > > [=A0=A0 46.140772] ast 0000:03:00.0: [drm] dram MCLK=3D800 Mhz ty=
pe=3D7
> > > > > bus_width=3D16
> > > > > [=A0=A0 46.153553] [drm] Initialized ast 0.1.0 20120228 for 0000:=
03:00.0
> > > > > on minor 0
> > > > > [=A0=A0 46.165097] fbcon: astdrmfb (fb0) is primary device
> > > > > [=A0=A0 46.391381] ast 0000:03:00.0: [drm] fb0: astdrmfb frame bu=
ffer device
> > > > > [=A0=A0 56.097697] systemd[1]: Starting Load Kernel Module drm...
> > > > > [=A0=A0 56.343556] systemd[1]: modprobe@drm.service: Succeeded.
> > > > > [=A0=A0 56.350382] systemd[1]: Finished Load Kernel Module drm.
> > > > > [13319.469462] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=
=A0=A0=A0=A0=A0 0=A0=A0=A0 73728
> > > > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> > > > > [13320.658386] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=
=A0=A0=A0=A0=A0 0=A0=A0=A0 73728
> > > > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> > > > > [13321.800970] [=A0=A0 2683] 70889=A0 2683=A0=A0=A0 55586=A0=A0=
=A0=A0=A0=A0=A0 0=A0=A0=A0 73728
> > > > > 138=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 tdrm
> > > >=20
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > dri-devel@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >=20
> > > --=20
> > > Thomas Zimmermann
> > > Graphics Driver Developer
> > > SUSE Software Solutions Germany GmbH
> > > Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> > > (HRB 36809, AG N=FCrnberg)
> > > Gesch=E4ftsf=FChrer: Felix Imend=F6rffer
> > >=20
> >=20
> >=20
> >=20
>=20
> --=20
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> (HRB 36809, AG N=FCrnberg)
> Gesch=E4ftsf=FChrer: Felix Imend=F6rffer

> sh: colordiff: command not found
> cat: write error: Broken pipe