Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbWINCvQ (ORCPT ); Wed, 13 Sep 2006 22:51:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751021AbWINCvQ (ORCPT ); Wed, 13 Sep 2006 22:51:16 -0400 Received: from de01egw01.freescale.net ([192.88.165.102]:57060 "EHLO de01egw01.freescale.net") by vger.kernel.org with ESMTP id S1750966AbWINCvP (ORCPT ); Wed, 13 Sep 2006 22:51:15 -0400 Subject: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support From: Zang Roy-r61911 To: Jeff Garzik Cc: Roland Dreier , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <4506C789.4050404@pobox.com> References: <1157962200.10526.10.camel@localhost.localdomain> <1158051351.14448.97.camel@localhost.localdomain> <4506C789.4050404@pobox.com> Content-Type: text/plain Organization: Message-Id: <1158202261.22615.0.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-4) Date: 14 Sep 2006 10:51:01 +0800 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Sep 2006 02:51:11.0199 (UTC) FILETIME=[A2C5D6F0:01C6D7A8] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 29 On Tue, 2006-09-12 at 22:43, Jeff Garzik wrote: > Roland Dreier wrote: > > > +struct tsi108_prv_data { > > > + volatile u32 regs; /* Base of normal regs */ > > > + volatile u32 phyregs; /* Base of register bank used for PHY > access */ > > > > Why volatile? This looks really wrong here. > > Indeed. I will remove it. > > > > > + data->regs = (u32)ioremap(einfo->regs, 0x400); /*FIX ME */ > > > + data->phyregs = (u32)ioremap(einfo->phyregs, 0x400); /*FIX > ME */ > > > > What needs to be fixed here? And why are you casting the result of > > ioremap to u32? Shouldn't you keep the normal return value? > > Oh, that's very, very wrong. I will find method to avoid this :-). Roy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/