Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2509916pxb; Mon, 18 Jan 2021 21:40:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9jqLTKKhcAWfmSJld4NtHk71cbaMX8nbmLCb4nMRKH8xGfoeiUUltQPjMY6nj+5Oz3VKZ X-Received: by 2002:a50:fb97:: with SMTP id e23mr2158767edq.208.1611034800636; Mon, 18 Jan 2021 21:40:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611034800; cv=none; d=google.com; s=arc-20160816; b=R0EcAbrPLQZUiqzzJ4IdUFIUpGZ0iE5VdYaRK0DIeAfhJEPU5kX1Xzqqlydo+nfXP+ K1zFAnsSosHUICP+a5mYAr6V9KZzQKCwQoSxOgfJRj5prQwZorOSqw7WGhEmEh7NmVI9 s+bKi/0gDK5ls3s82IPejvzmyusEzn8WquJZEikxcS1/8BhMftUIOAB16/7iHWZKsHeK vkt6MCzHUqiQWPSJfwi+ah2GuwMB33ER6QlcBjftjfTI74pREwot+S5MrnOpLk+12EC6 vCGtOl1FfLtS15BlbmKuG2pF1B8Q0j5gVLyiwxNdcU+auUnzxXnOJzRawmvlHqOWom/L WSNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=saOK2rQZ8LvjXL+D11visYuXDiXxSd5YTYGDgVAQGHk=; b=XIut8fIDej+8/y59Gg6QNOc4Iw1LDtysdVZSWzNI/35p/bXIgttFQ/aqU6vRlRvxCb oPb+aQN/vWG4bSydL4x73myFvEsk6byy9ZVGrbtWfk5WSJ14OWLyspYq0VDh6+yEq+AQ L2ojatD0URkRlAjythSHvH+zzY6VCrBUAGhYJJZuxJuI/8zdzpPJaJ0IxFidZCXj1wQ9 uUaw6SKVdIx/EdD7kNWbLS1OW/WjN5cwZxO3xprJfd/TU9yY0t5KEJQ//8tYyZnDwe5K H82Uy4tzFOKgAC2L2pLYTLWSYaS+4B0yBSUw1c5AeCY507OZx8ZC47sEwoxH6sVlhLpH bXtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YRcOscQG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h8si2103138edn.455.2021.01.18.21.39.37; Mon, 18 Jan 2021 21:40:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YRcOscQG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391611AbhASBGL (ORCPT + 99 others); Mon, 18 Jan 2021 20:06:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40936 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391322AbhASBGJ (ORCPT ); Mon, 18 Jan 2021 20:06:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611018276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=saOK2rQZ8LvjXL+D11visYuXDiXxSd5YTYGDgVAQGHk=; b=YRcOscQGp2DkqNg/sbo7Scw7kCq9Mul15qg1N4NFhob8yuHUqs9OnybFzqLJQWnO/mueKa 6xoP9kovQXjnaiG9TfvgnkXVISyBCftpazoxhEcNpCypDryd7fWggaYIxQwhLpiNHepF1s zyrBRqOllMLauthSmo+uSJt1k1CKrqI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-eF1HJRQnOjq782tDW6jN7Q-1; Mon, 18 Jan 2021 20:04:32 -0500 X-MC-Unique: eF1HJRQnOjq782tDW6jN7Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 627F13E751; Tue, 19 Jan 2021 01:04:30 +0000 (UTC) Received: from redhat.com (dhcp-17-185.bos.redhat.com [10.18.17.185]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F24F210023AB; Tue, 19 Jan 2021 01:04:28 +0000 (UTC) Date: Mon, 18 Jan 2021 20:04:27 -0500 From: Jarod Wilson To: David Ahern Cc: linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Jakub Kicinski , Thomas Davis , netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option Message-ID: <20210119010427.GB1191409@redhat.com> References: <20210113223548.1171655-1-jarod@redhat.com> <20210115192103.1179450-1-jarod@redhat.com> <79af4145-48cc-0961-b341-c0e106beb14b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79af4145-48cc-0961-b341-c0e106beb14b@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documentation/networking/bonding.rst > > +++ b/Documentation/networking/bonding.rst > > @@ -951,6 +951,19 @@ xmit_hash_policy > > packets will be distributed according to the encapsulated > > flows. > > > > + vlan+srcmac > > + > > + This policy uses a very rudimentary vland ID and source mac > > s/vland/vlan/ > > > + ID hash to load-balance traffic per-vlan, with failover > > drop ID on this line; just 'source mac'. Bah. Crap. Didn't test documentation, clearly. Or proof-read it. Will fix in v4. Hopefully, nothing else to change though... -- Jarod Wilson jarod@redhat.com