Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2510479pxb; Mon, 18 Jan 2021 21:41:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMCDzTh9VfcMpjeINYJfoVD5WEan/IuiAdBUWidebfjQzO5gM1cR0yO7I6PXrIo+GXF+lg X-Received: by 2002:a17:906:5285:: with SMTP id c5mr1996014ejm.17.1611034879110; Mon, 18 Jan 2021 21:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611034879; cv=none; d=google.com; s=arc-20160816; b=ZdUpyT/V9lQJU3NDIhM9rcHa9o4A/ICLZhV+GQVS56nu2uUezOsEND7YR+t9II0+Vh nQ8FV9VhLKhys5QNniZO3EvsmPMNIq1K54sHKGlRKxP9Lw47XdmlcNoOdd+YUGnG5gPh fD90WR47DTvuC9nsBoMfJ09YALi5W1TvgbCkWfqrndzuVQM9Y18lmP4kwkzzlXHlWkU6 ljQz0saSISzvGYfaUrdU22KJPGOkUQyRfUppfVkOtIVa1qZiOqo0RA1cJXEgjjM+ex5L uKF1qaJuSR0DiFSgvrnNOpOkgyHVPgtliWaU0tduotVAP6MOGjTuz7umbRxcLO/NBFsz x1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+UAgEF7q3tVgarE49rL6lz5qDhc929cOctxQXBBYdNI=; b=XKZ/0MKcNW0g3nBrLcSXWzxJd7QEXzgNeIKbHYiFEVcqNn7Y4awG4wGex2l9MOIOgX ViaecWnNl+KVgyaRzEsF3i/6tAt1UbwQWCi4iVwuRyZYOfnqn5HJY9wkVbVZWE1BVbgF aLCSRAn+Og8cKQt5uc1Cuepr7+ewRPIe7ncRjxC/ztZ4EPH9lSzWfNzebrXaZjwUhA/9 Zt62yY4t0hRTXg+tWkYOc+6eOWBKMx2YfJU3nJgBL37DGtlMRj3n3T9OIOqqMe5jwjaR Tvr4Ad6NFmmUsVOqv+64Z+S8hA05iZ3ZDDhgxNPGlclRPtNC4bIVoO8vFVQTXhOjZjIl W2iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZNFKSulY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si4613767eje.250.2021.01.18.21.40.56; Mon, 18 Jan 2021 21:41:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZNFKSulY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392797AbhASBv5 (ORCPT + 99 others); Mon, 18 Jan 2021 20:51:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30489 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392748AbhASBvs (ORCPT ); Mon, 18 Jan 2021 20:51:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611021021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UAgEF7q3tVgarE49rL6lz5qDhc929cOctxQXBBYdNI=; b=ZNFKSulYssNxUSJxQZmxj/Rd/WrmUOwaC2F40stYF9ttgWUBruZHiOnIvi/Jwc4Fbul+Wd H4hnOgeBNixQoaVpqfWlZPqr3yiSO77AwEu3S6Vdcd6+4lWJCfiufOtcCWgL8nNC9W0unc yd89TkPlimD/jh60MO7PZH1kpV+xBh8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-D5ZLNPQhPSy8QmHC89Ymtg-1; Mon, 18 Jan 2021 20:50:16 -0500 X-MC-Unique: D5ZLNPQhPSy8QmHC89Ymtg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4AF0A801817; Tue, 19 Jan 2021 01:50:15 +0000 (UTC) Received: from Whitewolf.lyude.net (ovpn-113-206.rdu2.redhat.com [10.10.113.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id 422591F471; Tue, 19 Jan 2021 01:50:13 +0000 (UTC) From: Lyude Paul To: nouveau@lists.freedesktop.org Cc: Martin Peres , Jeremy Cline , Simon Ser , Ben Skeggs , David Airlie , Daniel Vetter , Dave Airlie , dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/5] drm/nouveau/kms/nv50-: Use drm_dbg_kms() in crc.c Date: Mon, 18 Jan 2021 20:48:45 -0500 Message-Id: <20210119014849.2509965-2-lyude@redhat.com> In-Reply-To: <20210119014849.2509965-1-lyude@redhat.com> References: <20210119014849.2509965-1-lyude@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cc: Martin Peres Cc: Jeremy Cline Cc: Simon Ser Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/crc.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c index b8c31b697797..3c50b29a37ff 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c @@ -84,7 +84,8 @@ static void nv50_crc_ctx_flip_work(struct kthread_work *base) struct nv50_crc *crc = container_of(work, struct nv50_crc, flip_work); struct nv50_head *head = container_of(crc, struct nv50_head, crc); struct drm_crtc *crtc = &head->base.base; - struct nv50_disp *disp = nv50_disp(crtc->dev); + struct drm_device *dev = crtc->dev; + struct nv50_disp *disp = nv50_disp(dev); u8 new_idx = crc->ctx_idx ^ 1; /* @@ -92,18 +93,15 @@ static void nv50_crc_ctx_flip_work(struct kthread_work *base) * try again for the next vblank if we don't grab the lock */ if (!mutex_trylock(&disp->mutex)) { - DRM_DEV_DEBUG_KMS(crtc->dev->dev, - "Lock contended, delaying CRC ctx flip for head-%d\n", - head->base.index); + drm_dbg_kms(dev, "Lock contended, delaying CRC ctx flip for %s\n", crtc->name); drm_vblank_work_schedule(work, drm_crtc_vblank_count(crtc) + 1, true); return; } - DRM_DEV_DEBUG_KMS(crtc->dev->dev, - "Flipping notifier ctx for head %d (%d -> %d)\n", - drm_crtc_index(crtc), crc->ctx_idx, new_idx); + drm_dbg_kms(dev, "Flipping notifier ctx for %s (%d -> %d)\n", + crtc->name, crc->ctx_idx, new_idx); nv50_crc_program_ctx(head, NULL); nv50_crc_program_ctx(head, &crc->ctx[new_idx]); @@ -189,9 +187,9 @@ void nv50_crc_handle_vblank(struct nv50_head *head) * updates back-to-back without waiting, we'll just be * optimistic and assume we always miss exactly one frame. */ - DRM_DEV_DEBUG_KMS(head->base.base.dev->dev, - "Notifier ctx flip for head-%d finished, lost CRC for frame %llu\n", - head->base.index, crc->frame); + drm_dbg_kms(head->base.base.dev, + "Notifier ctx flip for head-%d finished, lost CRC for frame %llu\n", + head->base.index, crc->frame); crc->frame++; nv50_crc_reset_ctx(ctx); -- 2.29.2