Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent
To:     Isaac Chen <tingyi364@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <CobeChen@zhaoxin.com>,
        <TimGuo-oc@zhaoxin.com>, <QiyuanWang@zhaoxin.com>,
        <HerryYang@zhaoxin.com>, <CooperYan@zhaoxin.com>
References: <20210118172558.19426-1-tingyi364@gmail.com>
From:   Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
Message-ID: <a0fe603b-098c-65d7-9d60-f0365b7302ce@zhaoxin.com>
Date:   Tue, 19 Jan 2021 10:10:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20210118172558.19426-1-tingyi364@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/01/2021 01:25, Isaac Chen wrote:
> This is printed during kernel boot, match it with other supported x86 cpus.
>     [    0.000000] KERNEL supported cpus:
>     [    0.000000]   Intel GenuineIntel
>     [    0.000000]   AMD AuthenticAMD
>     [    0.000000]   Hygon HygonGenuine
>     [    0.000000]   Centaur CentaurHauls
>     [    0.000000]   zhaoxin   Shanghai
> 
> Signed-off-by: Isaac Chen <tingyi364@gmail.com>
> ---
>  arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
> index 05fa4ef63490..f155bbd2aa97 100644
> --- a/arch/x86/kernel/cpu/zhaoxin.c
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
>  #endif
>  
>  static const struct cpu_dev zhaoxin_cpu_dev = {
> -	.c_vendor	= "zhaoxin",
> -	.c_ident	= { "  Shanghai  " },
> +	.c_vendor	= "Zhaoxin",

Thanks for this patch.

> +	.c_ident	= { "Shanghai" },

The Vendor Identification String from CPUID leaf 0x00000000 of Zhaoxin
CPUs is not "Shanghai", ".c_ident = { "Shanghai" }," will cause the
matching of Zhaoxin CPUs fail.
Please do not modify ".c_ident = { "  Shanghai  " },".

Sincerely,
Tonyw