Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210118113032.21178-1-a.fatoum@pengutronix.de>
In-Reply-To: <20210118113032.21178-1-a.fatoum@pengutronix.de>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Mon, 18 Jan 2021 23:10:39 -0300
Message-ID: <CAOMZO5BdtfXoXMNr0Rsr5YTrahg6Pnz90eryksN4ctnSvOwU+A@mail.gmail.com>
Subject: Re: [PATCH v2] clk: imx6q: demote warning about pre-boot ldb_di_clk reparenting
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ahmad,

On Mon, Jan 18, 2021 at 8:30 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> Since 5d283b083800 ("clk: imx6: Fix procedure to switch the parent
> of LDB_DI_CLK"), the clock driver warns if ldb_di\d_sel is changed
> from reset value on system boot. This warning is printed even if
> the bootloader (or a previous kernel that did kexec) followed the
> correct procedure for glitch-free reparenting.
>
> As such systems are doing everything correctly, a warning is too
> harsh. Demote to a notice, so users are still alerted, but without
> cluttering a loglevel=5 boot.
>
> While at it, add the words "possible glitch" into the log message, to
> make it more user-friendly.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Reviewed-by: Fabio Estevam <festevam@gmail.com>