Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/4] MIPS: process: Some fixes and improvements about
 get_frame_info()
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
References: <1610454557-25867-1-git-send-email-hejinyang@loongson.cn>
 <ab6e4efb-98b5-3ad6-5bad-2338c57d9392@flygoat.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paul Burton <paulburton@kernel.org>,
        Jun-Ru Chang <jrjang@realtek.com>
From:   Jinyang He <hejinyang@loongson.cn>
Message-ID: <3397a977-939c-b9e5-cadb-11191765d338@loongson.cn>
Date:   Tue, 19 Jan 2021 09:29:34 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <ab6e4efb-98b5-3ad6-5bad-2338c57d9392@flygoat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 01/18/2021 09:51 AM, Jiaxun Yang wrote:

> 在 2021/1/12 下午8:29, Jinyang He 写道:
>> Not familiar with microMIPS. Not test on microMIPS.
>
> Hi Jinyang,
>
> I was messing around QEMU microMIPS and found kernel stuck
> at loading init process after applied your patches :-(
>
> Thanks.
>
> - Jiaxun
>

Hi, Jiaxun,

Thanks you for test.
I think the last patch went wrong.

+    if (ip->r_format.opcode == mm_pool32a_op &&
+        ip->r_format.func == mm_pool32axf_op &&
+        ((ip->u_format.uimmediate >> 6) & GENMASK(9,0)) == mm_jalr_op &&
+            ip->r_format.rs == 31)

There is no POOL32A format in uapi/asm/inst.h, so some bits here use the
format of r_format instead.

---------------------------------------------------------------------
|    format      |  31:26  | 25:21 | 20:16 |    15:6    |    5:0 |
-----------------+---------+-------+-------+------------+------------
| pool32a_format | pool32a |  rt   |  rs   |   jalrc    | pool32axf |
-----------------+---------+-------+-------+------------+------------
|    r_format    |  opcode |  rs   |  rt   | rd:5, re:5 |    func |
---------------------------------------------------------------------

I mistakenly thought that r_format.rs and pool32a_format.rs are the same.

+        return 1;
+    return 0;

Could you help me test it again?

Thanks,
Jinyang

>>
>> Jinyang He (4):
>>    MIPS: process: Reorder header files
>>    MIPS: microMIPS: Fix the judgment of mm_jr16_op and mm_jalr_op
>>    MIPS: Fix get_frame_info() handing of function size
>>    MIPS: Add is_jr_ra_ins() to end the loop early
>>
>>   arch/mips/kernel/process.c | 92 
>> +++++++++++++++++++++++++++++++---------------
>>   1 file changed, 62 insertions(+), 30 deletions(-)
>>