Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-45-g4839256-fm-20210104.001-g48392560
Mime-Version: 1.0
Message-Id: <d5630b5e-52ec-4fc7-b8f3-ac219d0bfbbb@www.fastmail.com>
In-Reply-To: <b08d641c-3fb5-4845-85f7-e1753149cd7d@www.fastmail.com>
References: <b08d641c-3fb5-4845-85f7-e1753149cd7d@www.fastmail.com>
Date:   Tue, 19 Jan 2021 14:15:58 +0900
From:   =?UTF-8?Q?Bla=C5=BE_Hrastnik?= <blaz@mxxn.io>
To:     "Jean Delvare" <jdelvare@suse.com>,
        "Guenter Roeck" <linux@roeck-us.net>,
        "Jonathan Corbet" <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        linux-doc@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Cc:     "David Bartley" <andareed@gmail.com>
Subject: Re: hwmon: (nct6683) Support ASRock boards.
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

(cc-ing David Bartley, who wrote the MSI patch)

I had a follow-up question: I noticed that support for MSI was added in
December, but there's this conditional that wasn't changed:

	/* Only update pwm values for Mitac boards */
	if (data->customer_id =3D=3D NCT6683_CUSTOMER_ID_MITAC)
		return attr->mode | S_IWUSR;

Should this continue to only apply for Mitac boards, or should it be cha=
nged to
!=3D NCT6683_CUSTOMER_ID_INTEL?

Bla=C5=BE