Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2546818pxb; Mon, 18 Jan 2021 23:04:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvpU4BBFTXOZ45+Tt1b9wwupqUwKFZZjf5mlo3PDbseg9cU0RonTcGxijEtTcW10w2tzah X-Received: by 2002:a05:6402:1c8b:: with SMTP id cy11mr2330647edb.256.1611039863337; Mon, 18 Jan 2021 23:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611039863; cv=none; d=google.com; s=arc-20160816; b=CNWCQv8+dYiJwfeYb6I8G5GsMtfSP8CcoE9exXzcs9ToNNrsjLEsFO/yi34egK5G2u upiNaesuvOK74XIrecPT79ISG4VHP7h2h4CZlZykmwOOFm4JLRrX6LaebaMDlMNa+f6I LweYXWK9BGSehvQo/yIYUa7XaeDqW+GyvJk60mteBoPVii8D0bexPG5sDixKMlwXi9cc 1/QYRQphll7OWrGkYpV8JbWylbyNvi/hoAfEog1NxVv/gpP1KCYpHD0OXnAuXXZUQOi1 PzJHNgtxyas2DJnVKeNr9tAchc2M4tCJm6aeuPs58hLlGgBzgGrm3+0hx5WAn2RkfDbZ ADOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=KldMGYQUzX6H4OGXUAXocK7z+o1ueLbOYMBKi4HtTw4=; b=YNCnu4fvkAPAf1R/RFi2zJTe8YkmqEmXL9pGNmNmnV+1s3hI/X7XEe7fa2mQQCq3ju PpPWqdrdwFX5xcEQXlCL1YAE6ZOBWGDtuejHMvN5DXeBea0oAfHm8Mfh6u/oZLvHGkbj nkVkWcNd7D2QweGBGfzyN34UjOFbngCPsuaNNl9SutuCqNpFr/hBmsW/TCEKG5OYM5md YzBjtE3CtQY/5tPYxp77zJGQDAehok8N9ZpYvIdt96lZMxAzaI4RSzgV5horO8GZOYQW 6P6LPXFXWYBAPEbhdjPaF0lhtQz00TbAAA5wfZgyyTGoBRnMIB1gxOrz0oPepNGfYSoz c1Tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf2si8278783ejb.154.2021.01.18.23.03.59; Mon, 18 Jan 2021 23:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbhASHC1 (ORCPT + 99 others); Tue, 19 Jan 2021 02:02:27 -0500 Received: from mga04.intel.com ([192.55.52.120]:59542 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729511AbhASHCM (ORCPT ); Tue, 19 Jan 2021 02:02:12 -0500 IronPort-SDR: yohp0pNJrzRtd1LwIKkf6udobFMROwxeYTYjddvDytoo/6Kz6kufZFspaDPVtK965fFYieqJOb RcCfa+y57Yog== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="176315503" X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="176315503" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 23:01:43 -0800 IronPort-SDR: QgMEs7Dtt8OusFvqMteOPWLCuCZkED8sb01FqVvbFxjQhhxatv+Jj/OSKl1Tx/LeEs8bIhd9PK xAgEHIdrGekQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="350417164" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.149]) ([10.237.72.149]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2021 23:01:38 -0800 Subject: Re: [PATCH v6 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off To: Bean Huo , alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210118201039.2398-1-huobean@gmail.com> <20210118201039.2398-2-huobean@gmail.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <0a9971aa-e508-2aaa-1379-fb898471a252@intel.com> Date: Tue, 19 Jan 2021 09:01:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210118201039.2398-2-huobean@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/21 10:10 pm, Bean Huo wrote: > From: Bean Huo > > Currently UFS WriteBooster driver uses clock scaling up/down to set > WB on/off, for the platform which doesn't support UFSHCD_CAP_CLK_SCALING, > WB will be always on. Provide a sysfs attribute to enable/disable WB > during runtime. Write 1/0 to "wb_on" sysfs node to enable/disable UFS WB. Is it so, that after a full reset, WB is always enabled again? Is that intended?