Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2574467pxb; Tue, 19 Jan 2021 00:05:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3HJe1qkeJuFXUKThWPwXfcXA6HGYV6z00Kim8Y9dCBjypCKQkzS4tMRdrhDT9HmFHWA8S X-Received: by 2002:a05:6402:37b:: with SMTP id s27mr2388827edw.266.1611043502690; Tue, 19 Jan 2021 00:05:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611043502; cv=none; d=google.com; s=arc-20160816; b=jj5VDFmnFmtMZxnrS9qUKOjm8RezAOkErPNsztA/Ia1lYiBukjzx1cF269H8RVrMEJ 3ErRb6TtuMWX0VO737Kxxt54UiUlsvfSHCQab/EprdROhaXQBsZkIaiJ/xbxp34ZEI2J iwgCj61TC5vLfCD0mFP7s9Vv+i7pQB8/lcup2Gf+cRu2zEnVCovnMqIULpsXOUfpNEpP spDlsifCOdGLLk8pC3Rbh2ZmZ67kAo2bEMUOi3lbgOKG7mXptiWWKQHDWkrDTb9tsNHQ /7WHLVl5E4PqoOwrF1IsZLuOKaVXtHIsOYjIqBn+yla4MDLb/QjDC8o7PBz/EnOi1vpX 0oYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Boqnpag10mDi2UFMUiP1wUUgPQP6dEE+EUCravI5wZg=; b=vy18/HOazggU8gi7StoYWqS86PFZXA1TASI3Sne4gEBb04bnBd9ZwX9zZ8BWf0luu1 sVWD94mYcwY+WwvU97UcFLbF0CC0splA84JQbvuQzV5KP6R8SmqX88KUDFzi+4VKaxjk lZNe7KSP7FPESWa90l7GA1VNpNf0rQOMfxNmSnTVt0fU+juuPhyKT4q3loPgQm7Eo2uQ nrs6tlQEOvP3ONOixHtq5MZ5QN43XBIeFJQN9opWt8K2X1EE579/pRuTNp60QEPSwuGp 3TTqzMQ6ttCGU206Bgnam6++YpG29sS/mODxt5TTc9+1cG1a/RKk6qZkbyNwWjqs2JNJ +X6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm25si8278247edb.109.2021.01.19.00.04.39; Tue, 19 Jan 2021 00:05:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730611AbhASIC5 (ORCPT + 99 others); Tue, 19 Jan 2021 03:02:57 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:59551 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730806AbhASIAE (ORCPT ); Tue, 19 Jan 2021 03:00:04 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R951e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UMDlRSu_1611043152; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0UMDlRSu_1611043152) by smtp.aliyun-inc.com(127.0.0.1); Tue, 19 Jan 2021 15:59:16 +0800 From: Jiapeng Zhong To: pkshih@realtek.com Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, Larry.Finger@lwfinger.net, chiu@endlessos.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Zhong Subject: [PATCH v3] rtlwifi: rtl8192se: Simplify bool comparison Date: Tue, 19 Jan 2021 15:59:10 +0800 Message-Id: <1611043150-78723-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the follow coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: WARNING: Comparison of 0/1 to bool variable. ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- Changes in v3: - Modified subject. drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c index 47fabce..aff8ab0 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c @@ -1373,7 +1373,7 @@ static void _rtl92se_gen_refreshledstate(struct ieee80211_hw *hw) struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); struct rtl_led *pled0 = &rtlpriv->ledctl.sw_led0; - if (rtlpci->up_first_time == 1) + if (rtlpci->up_first_time) return; if (rtlpriv->psc.rfoff_reason == RF_CHANGE_BY_IPS) @@ -2302,7 +2302,7 @@ bool rtl92se_gpio_radio_on_off_checking(struct ieee80211_hw *hw, u8 *valid) bool turnonbypowerdomain = false; /* just 8191se can check gpio before firstup, 92c/92d have fixed it */ - if ((rtlpci->up_first_time == 1) || (rtlpci->being_init_adapter)) + if (rtlpci->up_first_time || rtlpci->being_init_adapter) return false; if (ppsc->swrf_processing) -- 1.8.3.1