Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] venus: core: Fix platform driver shutdown
To:     Shawn Guo <shawn.guo@linaro.org>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        vgarodia@codeaurora.org,
        Mansur Alisha Shaik <mansur@codeaurora.org>
References: <20201221095820.27192-1-stanimir.varbanov@linaro.org>
 <20210119074044.GB17701@dragon>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
Message-ID: <72d85c1b-ec0b-3cf1-dbbc-6c4924e4beec@linaro.org>
Date:   Tue, 19 Jan 2021 09:59:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210119074044.GB17701@dragon>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/19/21 9:40 AM, Shawn Guo wrote:
> On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote:
>> With TZ system reboot cannot finish successfully. To fix that
>> enable core clocks by runtime pm before TZ calls and disable
>> clocks after that.
>>
>> Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus")
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> 
> Hi Mauro,
> 
> Could you help pick this fix up?

Shawn, it is part of linux-next already.

> 
> Shawn
> 
>> ---
>>  drivers/media/platform/qcom/venus/core.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
>> index bdd293faaad0..7233a7311757 100644
>> --- a/drivers/media/platform/qcom/venus/core.c
>> +++ b/drivers/media/platform/qcom/venus/core.c
>> @@ -349,8 +349,10 @@ static void venus_core_shutdown(struct platform_device *pdev)
>>  {
>>  	struct venus_core *core = platform_get_drvdata(pdev);
>>  
>> +	pm_runtime_get_sync(core->dev);
>>  	venus_shutdown(core);
>>  	venus_firmware_deinit(core);
>> +	pm_runtime_put_sync(core->dev);
>>  }
>>  
>>  static __maybe_unused int venus_runtime_suspend(struct device *dev)
>> -- 
>> 2.17.1
>>

-- 
regards,
Stan