Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2575806pxb; Tue, 19 Jan 2021 00:07:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxa0nFe70m1QWWFsPwudX6/A3z1eMSRrmMUMSwJd3pA8p6ZDDOYAdglA3jQOHv5DRUoiwtk X-Received: by 2002:a17:906:7798:: with SMTP id s24mr2238588ejm.19.1611043661662; Tue, 19 Jan 2021 00:07:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611043661; cv=none; d=google.com; s=arc-20160816; b=vjxjNZwdsWShglHFZR6fw7YrM9ORvfyoSq8Sotf07M8Sa6UvmdtxBw9vJ5VltP0UGZ 4ZrRUmlJ/F1zyOIMvWP8Rj2nMWO1r1NOH3ZW+I9/AIkdIAhYZqBTNOJIVFUJypJkdbC3 3IytR7Jox4LEaVHwCZcZXvExVZVmNZMqcYoJ5Q34z/tSsk/kYDAYNY0c3+1rpjJUpjVs RX+4Q6CYlD4lCG96ljJNhVkRwBGtECFA6Rxwcd6bp1ZxrBUu7b4GEirHmIDv0mA5T5q9 X2/x2Z+O4iTSgu/DmNBFYHdXnnXAIVicXtlNzOigxmLq/ahpAQ5YygWiKevZmnJNQZLE 7iFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dmarc-filter:sender:dkim-signature; bh=G6CrMrwkBlH/hAife+o1/KscQx/5H1OEZNAP7AT9sBg=; b=tx7FQiQ3wBZ5Vr6/pZQlw2Svsi6gxZc9huVpmlye6lLikE1bwl15fwq4uyOsGSNLVm ulpBcIQm2Q1eyPJdDgQyJtx0r7YDZScgyVJ3JPIncScj3jM9y+Z+J5+RlRD/fMpPK7LX Bye561/yPHKAPbti//3bePkoKx2YTdob6tDBt8y6G/xGMu5AWcJpLY9A4H5f//GsZMPQ kXL2DXAIKuCri5wrKjO/a8EzIPgY0IplnYnVbk3bJFDZUFsfBnWXFVaws4D40uUoLUu0 txap01ZHgmyEpnfQFjKk9V2ozBzZJc6TGb5Vx6RGvjJljf4Rjg+SLHpTUF8dqJ60co0k +uWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="A/7TMF18"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si4915156edn.332.2021.01.19.00.07.18; Tue, 19 Jan 2021 00:07:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="A/7TMF18"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728549AbhASIFF (ORCPT + 99 others); Tue, 19 Jan 2021 03:05:05 -0500 Received: from a1.mail.mailgun.net ([198.61.254.60]:64509 "EHLO a1.mail.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730945AbhASIEc (ORCPT ); Tue, 19 Jan 2021 03:04:32 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1611043452; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=G6CrMrwkBlH/hAife+o1/KscQx/5H1OEZNAP7AT9sBg=; b=A/7TMF18TF9/TxatgLX8LySEVilpoIpS/KMeWzI5fJCAWyuCBPK89Pyr210giejTUskeM6W3 40v5NNwxrj0X5u9lkNQaa/ulGYh1vb77MD7E28A6ogf4A9oUzn6l33lw7eGcmpEY6aimtooV qy8puVZ0WJUQTNtd0EFRVELl43I= X-Mailgun-Sending-Ip: 198.61.254.60 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6006925d75e5c01cba0b46ac (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 19 Jan 2021 08:03:41 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D376FC43463; Tue, 19 Jan 2021 08:03:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6F62C433CA; Tue, 19 Jan 2021 08:03:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A6F62C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pkshih Cc: "abaci-bugfix\@linux.alibaba.com" , "Larry.Finger\@lwfinger.net" , "linux-kernel\@vger.kernel.org" , "chiu\@endlessos.org" , "kuba\@kernel.org" , "netdev\@vger.kernel.org" , "davem\@davemloft.net" , "linux-wireless\@vger.kernel.org" Subject: Re: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison. References: <1611037955-105333-1-git-send-email-abaci-bugfix@linux.alibaba.com> <1611041680.9785.1.camel@realtek.com> Date: Tue, 19 Jan 2021 10:03:36 +0200 In-Reply-To: <1611041680.9785.1.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 19 Jan 2021 07:35:19 +0000") Message-ID: <87v9btqron.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pkshih writes: > On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote: >> Fix the follow coccicheck warnings: >>=20 >> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: >> WARNING: Comparison of 0/1 to bool variable. >>=20 >> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: >> WARNING: Comparison of 0/1 to bool variable. >>=20 >> Reported-by: Abaci Robot >> Signed-off-by: Jiapeng Zhong >> --- >> Changes in v2: >> =C2=A0 -Modified subject. >>=20 > > You forget to remove the period at the end of subject. > i.e. > "rtlwifi: rtl8192se: Simplify bool comparison" I can fix that during commit. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes