Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210114130316.803231-1-ribalda@chromium.org> <d472a1b1-71d6-0c9c-0ead-d2287bd788ae@embeddedor.com>
In-Reply-To: <d472a1b1-71d6-0c9c-0ead-d2287bd788ae@embeddedor.com>
From:   Ricardo Ribalda <ribalda@chromium.org>
Date:   Tue, 19 Jan 2021 09:57:00 +0100
Message-ID: <CANiDSCt5o-k=8L2YhpYCQhWJhsE7vHJ_u6TFgFu0a9gAyT49TQ@mail.gmail.com>
Subject: Re: [PATCH] media: hantro: Fix reset_raw_fmt initialization
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Ezequiel Garcia <ezequiel@collabora.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Gustavo

On Mon, Jan 18, 2021 at 11:26 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Hey Ricardo,
>
> On 1/14/21 07:03, Ricardo Ribalda wrote:
> > raw_fmt->height in never initialized. But width in initialized twice.
>
> Nice catch!
Thanks :)

>
> How did you find this?

Pure luck. I was backporting a patch and the duplicated line hit my
eye. Maybe we could just search for duplicated lines in the codebase.
I guess it is not the only c&p issue we have

>
> > Fixes: 88d06362d1d05 ("media: hantro: Refactor for V4L2 API spec compliancy")
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> This should be tagged for -stable:
>
> Cc: stable@vger.kernel.org
>
> --
> Gustavo
>
> > ---
> >  drivers/staging/media/hantro/hantro_v4l2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers/staging/media/hantro/hantro_v4l2.c
> > index b668a82d40ad..f5fbdbc4ffdb 100644
> > --- a/drivers/staging/media/hantro/hantro_v4l2.c
> > +++ b/drivers/staging/media/hantro/hantro_v4l2.c
> > @@ -367,7 +367,7 @@ hantro_reset_raw_fmt(struct hantro_ctx *ctx)
> >
> >       hantro_reset_fmt(raw_fmt, raw_vpu_fmt);
> >       raw_fmt->width = encoded_fmt->width;
> > -     raw_fmt->width = encoded_fmt->width;
> > +     raw_fmt->height = encoded_fmt->height;
> >       if (ctx->is_encoder)
> >               hantro_set_fmt_out(ctx, raw_fmt);
> >       else
> >


-- 
Ricardo Ribalda