Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2660899pxb; Tue, 19 Jan 2021 02:58:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2NGQZRq8+A8Cuno671cNjEOGNNTfId4OChvSAgsRQcyrBcnFLqvL0kx2uNiCJEABfW84f X-Received: by 2002:a17:906:2407:: with SMTP id z7mr2646118eja.219.1611053927197; Tue, 19 Jan 2021 02:58:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611053927; cv=none; d=google.com; s=arc-20160816; b=Ce47zqGynd0DxtdwPsMJ1Df3jI/psY9FaZHG94G2qVdFbriAeWExeRSLHSYuqsM0AU kMJ2YF8vTVun0540sFRlO1b/VD86Jl0HaiNpkX+ZGGLty38UvnstnCOJugyD1+tKZb6L q86ZCmrqRMrWBgpQlrGbLxF7gUB46T57fj48nezpk27ki3uMzVTYLph1OAEUF0kQb2YP +yLb7pT2D88K3DDfMYPE6EO69Bd1gu4LLr6BC5mDgWkeUv79+b1ysBYAH8cGSyt09M2Q FXUhOdTQElJEzpaXqoVeboKoc0FskaloI7Un8jO1+OyeG4a/3vxt5lqov/KIV7UDzlWZ hunA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=irOGx2i6bh30eEntjXBDPx9QUktkG077HiS/kom/5lE=; b=bdFF4JefvXRw/Ui84HBEexpWWAOUxm4r8dua0mtEp8pTsFEMBptsAQuy8I8gJFaMMc ae60UA59yfWkpdWCgWwrydhNBDH85gbkZjnC4T3321/FEGts9KK+ohOePilzy25cIFd4 vaRluuWB3F0qGlu0w+r3dSE0mZkYhpsH4rvvEcoXc5/BTlr6zP/h+tFssLZXWmSkpb1/ I6RyNMtNZs1DpgATzfH1Nh6zhwJSyl+eSN0YAWdsFrlYbc0N3JwRn9VOYoZLbDuzLT1W oZKA3TCsbsxJQJjgV43PhzioW00n9BXTvgNmBvNRFmUvfzfYqezjfxvEr/8xzNt7w2rq /mxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si5055180edp.417.2021.01.19.02.58.24; Tue, 19 Jan 2021 02:58:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389519AbhASKFe (ORCPT + 99 others); Tue, 19 Jan 2021 05:05:34 -0500 Received: from mga05.intel.com ([192.55.52.43]:56091 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731808AbhASJm5 (ORCPT ); Tue, 19 Jan 2021 04:42:57 -0500 IronPort-SDR: 2+0q67q8GBU3/KckoNoXFYkGbkfh/R04KpJtvCyHA7qOLu3mE9mUwrrahVNWr5XELwKSuaJ9fg W5lRDlnF3Cgw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="263710730" X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="263710730" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 01:41:00 -0800 IronPort-SDR: 4TZ3Mo3Tu7C/tfZdY7fsSqYsn9yNgc+q6areqBN1q+dAU4F8Pn89V95q9Ae319iCJELd6D6ztg PezPEO3U27Yg== X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="365678805" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 01:40:57 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1nWR-003M1r-QO; Tue, 19 Jan 2021 11:41:59 +0200 Date: Tue, 19 Jan 2021 11:41:59 +0200 From: Andy Shevchenko To: Kai-Heng Feng Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , AceLan Kao , "Rafael J. Wysocki" , Mika Westerberg , Len Brown , "open list:ACPI" , open list Subject: Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias Message-ID: <20210119094159.GQ4077@smile.fi.intel.com> References: <20210119081513.300938-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman > wrote: > > On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: ... > > Who will use OF_MODALIAS and where have you documented it? > > After this lands in mainline, I'll modify the pull request for systemd > to add a new rule for OF_MODALIAS. > I'll modify the comment on the function to document the change. I'm wondering why to have two fixes in two places instead of fixing udev to understand multiple MODALIAS= events? -- With Best Regards, Andy Shevchenko