Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v2
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     daniel@ffwll.ch, mingo@redhat.com, will@kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20210118180334.43714-1-christian.koenig@amd.com>
 <20210118180334.43714-2-christian.koenig@amd.com>
 <YAan6haGjnIlNIoJ@hirez.programming.kicks-ass.net>
 <019f2342-9d64-f6c6-d03d-0ab8ddce101d@gmail.com>
 <YAau1CBmMNPM5KqV@hirez.programming.kicks-ass.net>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <ebf6940b-223c-9b92-3220-a79063723373@amd.com>
Date:   Tue, 19 Jan 2021 11:08:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YAau1CBmMNPM5KqV@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM8P190CA0017.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Tue, 19 Jan 2021 10:08:59 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 56d71303-a445-477d-a467-08d8bc623ded
X-MS-TrafficTypeDiagnostic: BL0PR12MB4706:
X-Microsoft-Antispam-PRVS: <BL0PR12MB4706F0C66ABBB3E1E767DD6B83A30@BL0PR12MB4706.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:41;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: M74RmmDa8/xTMC9V/xcEOASS5owmU1Uag2bv3PivE0sOnlKj23hkZtkUznQa4ri0oe+hPmd52xT1qwtCt1YmCcCADHgfveplAhP/D5StH5P86OVZ6XdPi4wKKUrGsL3/NZVVfw8avFIXCtbv98WfGBn8OoZSqwtQZLPl6iXllRi70Ah1Oxw6fKqIYCC7azjGyims7ZjFpusn3NzSdIGaMtndhBFWxajBHu9A7QlkwIs1FPou/CvvaIKd0JfTivbwEsxa3WWmhsUbb+ILs90QsbPzS5YcO2EPYW/2rKaxTXBuDUB4tao1lxWNdVIdGTU24SnwH97OF32dkRVWi2laJR2910y90m50iOgnjh0vFNUxTmSM45Y/2Bn7arPJ7lFk9hrV0nkF5z7yt6RbZpkukD53xN3n7Gj+BCAT+uz+TpCG/B4ZACoeUOXzrnj6zU2aHcigTPXSBPbA2I1DLiEgo93Tx/NDl37pR4SpjM1VnP9Qifw+rspSgs0l+iEdJo8qKKuUZGgeRrDn3j0QO9CUBV2u0k+YXAlE6gcG6GjxV1JBTBgd74Ag2l09ViLxQVpTQhmoFGUWdQtMP11HeyMINWx4p48my+/v+kORT6npbfE=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(376002)(346002)(366004)(136003)(8936002)(83380400001)(31696002)(6486002)(316002)(4744005)(8676002)(66556008)(186003)(66946007)(36756003)(86362001)(31686004)(6916009)(5660300002)(2616005)(16526019)(52116002)(66476007)(478600001)(6666004)(4326008)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MyszUlJVMHJrUXZMTy9Qck5tNmNQbi95THErdUZwVWQxMUpmL3FxTXRhZHZa?=
 =?utf-8?B?UVhLWGlNOWphazlxdG9Zc3lUUGpWRCtaVHNKbWRSZDhsbFlZRUhXSVRlQ3VZ?=
 =?utf-8?B?VkttMFc2bzU2VEZwR3E4a1Q2UTF0Q2ZFTFkvL1RVOHZHSWRsbTJkcWQzM08x?=
 =?utf-8?B?TXFNVzJuYkNwZzFBanR0U3llYmF0RXE1R2w5d3R1YjcwQUt5ZUJZSWdWajYv?=
 =?utf-8?B?WU56ejM4d09BTHJLazJJM0o3TkRqSXVSZ1FaL3pqMFhZUG83UEgrdWt0VEVO?=
 =?utf-8?B?S1FRS3laMEZIUHl4OXNqK0txeUdXV3gwS01JSEl1eWt2QlBVT1pwZUdRdzRw?=
 =?utf-8?B?aWhPRUtuUlBITkg1ZVFsRDJJT2tiSVJXOENVbmtyeDZYL294WmpvbFR0UmNC?=
 =?utf-8?B?Q29tR3E2bWtTL3ZtN0xoK3lQcUZJVFVnU251TTBQNmRkMERMaGtzOUgvaDJT?=
 =?utf-8?B?Z3RURFBPcDAxMmRteU9qL0pRcjhKbkdiR2hIa3hQN0Z3cGpDY1lzdmZlaGhz?=
 =?utf-8?B?T1lSdzBKUXRPUXpwbTFzOUNxaDU5R3hBZ3FtU05XN2kyWjZEVmJkaUlUZmlN?=
 =?utf-8?B?S3cwN2xXOGNrQVAvSnJnWm5CR0dWWUpkR2NabUkzbzI4YVIvRjAzTFlxK1dW?=
 =?utf-8?B?VkcyT3FmNmY3cTJMNFYrTzE1NC84cWJHb25xK0cvZi8xUzVoS1BjbHdNRUdV?=
 =?utf-8?B?djltL1ZqMUsvQjI2WFBCakVaN2dYSW03N0dVV3BZNkRZblp3M0pNaDhWQ2VD?=
 =?utf-8?B?b0J2eWNsWkFweEZkdXVETnhOd2Riamk4U0F4N2I4TGp1VFV3VDN1WlNvbGY4?=
 =?utf-8?B?RHhleE4rNnRsOEY5eGFZc01sUGdRazltem8xSDhTUytNMmxHRWkvbGZLRU1n?=
 =?utf-8?B?d25HWnRIakcxajBGTkxNOFhlNFlIUUlSWGxNRUtkY0dCNnRxVFY4SkMxdDNs?=
 =?utf-8?B?bVRmeVY3ekN3R0tkcTZZZDVlUDMxa3hpQWdDdUxyZmZxWXFCUkk1MWI3by94?=
 =?utf-8?B?OSs4SVJuRU9jVVBKV1FRRWk0UW02VVdVN2NsVTVrd09Td0NtVzhRcGRCRHRO?=
 =?utf-8?B?MXRGN2pIOGx3R1d3Mm1hSXRlSjBtbXpuVno5dTIyMGtCSnQzbHVnZjl4MEhJ?=
 =?utf-8?B?RlE1UjlUcEpad1p5TjFpZEJJemJ0cGh3OTdEYW1NK05kWEVXd1hNR2FMRW1i?=
 =?utf-8?B?U2V3aE0yOXhVTDFjSG5UVkRuYlN2dUZTTDc4VTNOS0tCai9LcW1FZUZ3SHVq?=
 =?utf-8?B?L3cxRE5nUUoyRGVaV2FkMFZvdk1iYk5IazNLRm9zeFh1UzVrYk9KMFRKNGpw?=
 =?utf-8?B?RjRYUkVlRkRzaGwxSFlJcHBHc1VxSUFnMUdMOHZBQk9pN0RXY3ZMK1VPY2pu?=
 =?utf-8?B?Qnhwd0xWeFVrVG1RY0VqL0dldUx3SDNtOVNVQUhjdzMvemtQLzUrL0s1d3U1?=
 =?utf-8?B?bmhJcnVHc1ZLQTlsQnNZWmxFaHlDa2Znclc2NFRORThvT0p5RkNUTldDREdu?=
 =?utf-8?B?V0JwRjNPWlFIV0RZTDZzWWxJb1Jab3JSZUFUNm96clFUZk80b3ZsQzdWR21w?=
 =?utf-8?B?K1pwZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56d71303-a445-477d-a467-08d8bc623ded
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2021 10:09:00.7634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AO1iS9v29vGkuHdMyIDcrDDrLfUScuB70gBfRXb+7mucPKoJvkkUolzogpQDLo4E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4706
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 19.01.21 um 11:05 schrieb Peter Zijlstra:
> On Tue, Jan 19, 2021 at 10:46:53AM +0100, Christian König wrote:
>> But I'm going to double check if drm_syncobj_fence_add_wait() isn't used
>> elsewhere as well.
> drm_syncobj_array_wait_timeout()
>
> Which is why I asked.. :-)

Ok, good point as well. But this isn't driver interface and rather IOCTL 
implementation.

So if we hold any locks there it is our own stupidity. Going to add the 
appropriate annotation anyway.

Thanks,
Christian.