Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 11:22:43 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Howard Yen <howardyen@google.com>
Cc:     robh+dt@kernel.org, mathias.nyman@intel.com,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: usb: usb-xhci: add USB offload support
Message-ID: <YAay83Ze47hNu5Ii@kroah.com>
References: <20210119101044.1637023-1-howardyen@google.com>
 <20210119101044.1637023-5-howardyen@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210119101044.1637023-5-howardyen@google.com>
Precedence: bulk

On Tue, Jan 19, 2021 at 06:10:44PM +0800, Howard Yen wrote:
> Document USB offload support for usb-xhci.
> 
> For example:
> 
> &usbdrd_dwc3 {
> 	...
> 	/* support usb offloading, 0: disabled, 1: audio */
> 	offload = <1>;
> 	...
> };
> 
> Signed-off-by: Howard Yen <howardyen@google.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index b120dd6612a2..aab1fd499f15 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -46,6 +46,7 @@ Optional properties:
>    - quirk-broken-port-ped: set if the controller has broken port disable mechanism
>    - imod-interval-ns: default interrupt moderation interval is 5000ns
>    - phys : see usb-hcd.yaml in the current directory
> +  - offload: supporting USB offload feature, 0: disabled, 1: audio

Why does the "type" of offload matter, shouldn't it just be:
	0: disabled, 1: enabled
?

And in thinking about it some more, why does this need to be a binding
at all, shouldn't this just be an issue if the platform-specific ops are
available or not, meaning no DT change should be needed at all?

thanks,

greg k-h