Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2687172pxb; Tue, 19 Jan 2021 03:43:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOnLKxm97iAiTZ669SqJsPGcQxZNhYCRzq+0COnYCMcjANuKyU0xkM6h34DYqXykSXvbjR X-Received: by 2002:a17:906:c40e:: with SMTP id u14mr2708814ejz.547.1611056586864; Tue, 19 Jan 2021 03:43:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611056586; cv=none; d=google.com; s=arc-20160816; b=1BFS7ADNSf0YMWXiBKkaLBdJLMQ+Hft0Z3tavgVKs6AzX17BGI4S6uJmWBXdnpea5V n/7jlJLfuiJBR/RrBzv5LhCOR3D/2Iuw5d0JkqSvhtDcVivDsHnPG1FB1WWPq06O9kZu EwJG0gDuR0qB4ylsWcw9OhfsCuGP+NzYfaq8G+G7AVpRTLWNEkr4iLK4qovh752W0rPR EEbyDwXAOIXH/1xK4ebpjMbydQu8Yt9RlO1R3iGP0iPGRS9wgKlglAzuRmfaoCY6Gmzf Mv0SkCCzJNssMunZfPGLnUbAdxSQrwrrwfu09HbvWYD0pIKL25XoIHrP/5NI8TEziDlq pIaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4CqezFVMKH36MJrRgW74iAw00guuFWAyVYHxCYgTsAo=; b=lm2XJjklJIo6GrKyIH03/Rhmo82SZzVTXtQoU7m7LxRHBlBx09+eQ3lEnTq8Fzj0RL AcpDQqtr3Cp++ieLEH/MJttxVDl9k18QoO121qz5SQjeryXpQE09hPU4TzzQie3ML1D6 drZSza0VX7qpbx7cdPq4RQPzN+P6jYCG3lyMJIOao0uvKhlelIMdIhc2PZXQHYVdeVQ1 EuAvC35Ko4yGWW6d1Q41qQfaq99KCjaxYlxZdQMWlNAbPSr7sUv/mwcq7NRUZv93hYsF me8d5ZUBnTztzt44EhuYJvns9jq8rTdoUNpMZ7rjITZww/OtWvEFWoXUQTBHmFg/9HPJ tR+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Gh928GzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si7844636eja.539.2021.01.19.03.41.09; Tue, 19 Jan 2021 03:43:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Gh928GzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403897AbhASKdM (ORCPT + 99 others); Tue, 19 Jan 2021 05:33:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389840AbhASKRk (ORCPT ); Tue, 19 Jan 2021 05:17:40 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D86C061573; Tue, 19 Jan 2021 02:16:57 -0800 (PST) Received: from zn.tnic (p200300ec2f0bca00c2aa0e949335efb7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:ca00:c2aa:e94:9335:efb7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 90EF01EC05C4; Tue, 19 Jan 2021 11:16:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1611051415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4CqezFVMKH36MJrRgW74iAw00guuFWAyVYHxCYgTsAo=; b=Gh928GzQ6JGqQd2EW/IdX6MUCu5eog1EnJbJ0axAHdcj9ENc7N/VVzoc4FtcQm05sF5ZwP 2/wg3n5xOEbbdNsvS9nLyb0maPeMkPBArRD7oUCCZRXjk/9sqB5ZKp1SwL1beqC6G/V8ku 7fJUgJBNNv9kQz7g5639id4DLBTHtwQ= Date: Tue, 19 Jan 2021 11:16:55 +0100 From: Borislav Petkov To: Shiju Jose Cc: "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "james.morse@arm.com" , "mchehab+huawei@kernel.org" , "tony.luck@intel.com" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "rrichter@marvell.com" , Jonathan Cameron , tanxiaofei , "linuxarm@openeuler.org" Subject: Re: [RFC PATCH 1/2] EDAC/ghes: Add EDAC device for the CPU caches Message-ID: <20210119101655.GD27433@zn.tnic> References: <20201208172959.1249-1-shiju.jose@huawei.com> <20201208172959.1249-2-shiju.jose@huawei.com> <20201231164409.GC4504@zn.tnic> <20210118183637.GD30090@zn.tnic> <51d4ecaf997043718d3066e0a45518d2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <51d4ecaf997043718d3066e0a45518d2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 10:04:23AM +0000, Shiju Jose wrote: > This EDAC code for the cache errors is architecture independent for the > firmware-first error reporting and could be used for other architectures, I'm not so sure about that because you're lumping all the cache hierarchies together and there might be L3 slices on some x86 incarnations, for example, which do not belong to the core you're reporting the error for... It would need to be tested though. Also, if this is a firmware-first mode, then I would expect the firmware to also report which cache triggered the error and thus not need any OS glue at all. Therefore ARM only and I'd need an ACK from ARM folks whether they want it this way. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette