Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 13:43:39 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kari Argillander <kari.argillander@gmail.com>,
        Julia Lawall <Julia.Lawall@inria.fr>
Cc:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
        aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
        joe@perches.com, mark@harmstone.com, nborisov@suse.com,
        linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com, hch@lst.de,
        ebiggers@kernel.org, andy.lavr@gmail.com
Subject: Re: [PATCH v17 01/10] fs/ntfs3: Add headers and misc files
Message-ID: <20210119104339.GA2674@kadam>
References: <20201231152401.3162425-1-almaz.alexandrovich@paragon-software.com>
 <20201231152401.3162425-2-almaz.alexandrovich@paragon-software.com>
 <20210103231755.bcmyalz3maq4ama2@kari-VirtualBox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210103231755.bcmyalz3maq4ama2@kari-VirtualBox>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Jan 04, 2021 at 01:17:55AM +0200, Kari Argillander wrote:
> On Thu, Dec 31, 2020 at 06:23:52PM +0300, Konstantin Komarov wrote:
> 
> > +int ntfs_cmp_names(const __le16 *s1, size_t l1, const __le16 *s2, size_t l2,
> > +		   const u16 *upcase)
> > +{
> > +	int diff;
> > +	size_t len = l1 < l2 ? l1 : l2;
> > +
> > +	if (upcase) {
> > +		while (len--) {
> > +			diff = upcase_unicode_char(upcase, le16_to_cpu(*s1++)) -
> > +			       upcase_unicode_char(upcase, le16_to_cpu(*s2++));
> > +			if (diff)
> > +				return diff;
> > +		}
> > +	} else {
> > +		while (len--) {
> > +			diff = le16_to_cpu(*s1++) - le16_to_cpu(*s2++);
> > +			if (diff)
> > +				return diff;
> > +		}
> > +	}
> > +
> > +	return (int)(l1 - l2);
> > +}
> 
> I notice that these functions might call both ignore case and upcase in a row.
> record.c - compare_attr()
> index.c - cmp_fnames()
> 
> So maybe we can add bool bothcases.
> 
> int ntfs_cmp_names(const __le16 *s1, size_t l1, const __le16 *s2, size_t l2,
> 		   const u16 *upcase, bool bothcase)
> {
> 	int diff1 = 0;
> 	int diff2;
> 	size_t len = l1 < l2 ? l1 : l2;

size_t len = min(l1, l2);

I wonder if this could be a Coccinelle script?

regards,
dan carpenter