Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210119031813.16980-1-rdunlap@infradead.org>
In-Reply-To: <20210119031813.16980-1-rdunlap@infradead.org>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Tue, 19 Jan 2021 12:10:59 +0100
Message-ID: <CAMpxmJWNDLoLEYepj8AtssfYuttOPE9R6D=HF_Nf=Nb0mW_Cyw@mail.gmail.com>
Subject: Re: [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than
 depend on it
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        Greentime Hu <greentime.hu@sifive.com>,
        Yash Shah <yash.shah@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 19, 2021 at 4:18 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> This is the only driver in the kernel source tree that depends on
> IRQ_DOMAIN_HIERARCHY instead of selecting it. Since it is not a
> visible Kconfig symbol, depending on it (expecting a user to
> set/enable it) doesn't make much sense, so change it to select
> instead of "depends on".
>
> Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Greentime Hu <greentime.hu@sifive.com>
> Cc: Yash Shah <yash.shah@sifive.com>
> ---
>  drivers/gpio/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20210118.orig/drivers/gpio/Kconfig
> +++ linux-next-20210118/drivers/gpio/Kconfig
> @@ -521,7 +521,8 @@ config GPIO_SAMA5D2_PIOBU
>
>  config GPIO_SIFIVE
>         bool "SiFive GPIO support"
> -       depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
> +       depends on OF_GPIO
> +       select IRQ_DOMAIN_HIERARCHY
>         select GPIO_GENERIC
>         select GPIOLIB_IRQCHIP
>         select REGMAP_MMIO

Applied, thanks!

Bart