Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 12:34:23 +0000
From:   Alessio Balsini <balsini@android.com>
To:     Rokudo Yan <wu-yan@tcl.com>
Cc:     balsini@android.com, akailash@google.com, amir73il@gmail.com,
        axboe@kernel.dk, bergwolf@gmail.com, duostefano93@gmail.com,
        dvander@google.com, fuse-devel@lists.sourceforge.net,
        gscrivan@redhat.com, jannh@google.com, kernel-team@android.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        maco@android.com, miklos@szeredi.hu, palmer@dabbelt.com,
        paullawrence@google.com, trapexit@spawn.link, zezeozue@google.com
Subject: Re: [PATCH RESEND V11 0/7] fuse: Add support for passthrough
 read/write
Message-ID: <YAbRz83CV2TyU3wT@google.com>
References: <20210118192748.584213-1-balsini@android.com>
 <20210119110654.11817-1-wu-yan@tcl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210119110654.11817-1-wu-yan@tcl.com>
Precedence: bulk

On Tue, Jan 19, 2021 at 07:06:54PM +0800, Rokudo Yan wrote:
> on Mon, Jan 18, 2021 at 5:27 PM Alessio Balsini <balsini@android.com> wrote:
> >
> > This is the 11th version of the series, rebased on top of v5.11-rc4.
> > Please find the changelog at the bottom of this cover letter.
> > 
> > Add support for file system passthrough read/write of files when enabled
> > in userspace through the option FUSE_PASSTHROUGH.
> [...]
> 
> 
> Hi Allesio,
> 
> Could you please add support for passthrough mmap too ?
> If the fuse file opened with passthrough actived, and then map (shared) to (another) process
> address space using mmap interface. As access the file with mmap will pass the vfs cache of fuse,
> but access the file with read/write will bypass the vfs cache of fuse, this may cause inconsistency.
> eg. the reader read the fuse file with mmap() and the writer modify the file with write(), the reader
> may not see the modification immediately since the writer bypass the vfs cache of fuse.
> Actually we have already meet an issue caused by the inconsistency after applying fuse passthrough
> scheme to our product.
> 
> Thanks,
> yanwu.

Hi yanwu,

Thank you for your interest in this change.

FUSE passthrough for mmap is an extension that is already in my TODO
list, together with passthrough for directories.
For now I would prefer to keep this series minimal to make the review
process leaner and simpler.
I will start working on extending this series with new features and
addressing more corner cases as soon as these changes get merged, what
do you think?

Thanks,
Alessio