Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2836747pxb; Tue, 19 Jan 2021 07:18:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhKXasdZHAVs7He8iBGjCNljYA+AS+VgD+jByoYmjEsVHdU+mOXl//8sNjeBy+VtJRJx9c X-Received: by 2002:a50:9310:: with SMTP id m16mr3897550eda.94.1611069506218; Tue, 19 Jan 2021 07:18:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611069506; cv=none; d=google.com; s=arc-20160816; b=Txv7I8AsnfSDnpP4CuD6kMpy3nSIEVXW82bwEoqC5Cfz5eg0fs924rYfdYouBUoC0J pCvPm+nLFcOcRxH++7+EqxzLxKCehRbW1bZ//asiAa06EFUD7BA4AgBQ80BEAg2w/8fl QbnUCbN0mWRKlKBfMXDGThwrnfDw4V69kG7ygo2rz8vDZ2eKC4BI1ujl+ewXpbbbbxu9 9PeUdPmY3yWf0MUtu5T/itpNAfmKaRE17WiRhsTAcRYD7aefSgW5fdnIB014aVS9iTxZ sS/OJwsnGWjgi/QzvDKJ2zr0q+kaY4ovsq32x/a+SFkO36L68sJQB9vtYeClPb0xLiRz wUow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=0t6RhR/1R2XdCgrNs9/OaQXmFfvvtj4DhEfvATabpOA=; b=JtVuldc2kBYmusCv6Faly8oRhhY8zQWOpO6+TtxNpg4sNaz4MJJORzE1r52Vc7pVh7 7ZHmbk7mPZPDu/Vz2GyZNG65PsxsobXMo3REvFg5czI4Hrs3XGyVL/iVsF8j30A9m09p j/XudolZ1/MDisDG9H1tlL91f2Ky1nHfvPJp3T1nwduF5s8wdm1GgrBc1dSjVV7ZMLQc /2bJ1+5NFHtLAFPjLcljpoSnDeczUIH1NearWzoqUd7wqnqcKQq99rputdptgfahIOI4 5bb6/LV2uSJ8uPASaPx6E3Aa/DJluRABiUh3cczn5LVDBtPxhdliTex6bmHerZePSuSI eKDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si4382818ejr.63.2021.01.19.07.18.02; Tue, 19 Jan 2021 07:18:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387465AbhASPRX (ORCPT + 99 others); Tue, 19 Jan 2021 10:17:23 -0500 Received: from mail-ot1-f48.google.com ([209.85.210.48]:38353 "EHLO mail-ot1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391250AbhASPNO (ORCPT ); Tue, 19 Jan 2021 10:13:14 -0500 Received: by mail-ot1-f48.google.com with SMTP id 34so9241230otd.5; Tue, 19 Jan 2021 07:12:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0t6RhR/1R2XdCgrNs9/OaQXmFfvvtj4DhEfvATabpOA=; b=lu+/uWBJBNlyhTNilTvHcLLym4xbOFgIEmDrBU+2VzChQILygAFpvtbyfgGiQgwBdA UdhP1E4CH+G1epDeWEkOJAxmkpetN6kv/EYF3KPsM3G6GbkijrTRaHUa35kkGqJ578oK NjGD0n+yH+0FbSRIgR8jz9FQoDi2BRsiweTyH1aRwu1bTf99O6Yo3PYjpOIzH26aY/QM E17vv5AsBh+6FF7gM5ILg2XPzd3nKNhxURz5uBMpMKc1LtrJyY3quQQdUcN4GxYk/Kio t8/vwU0Y6rgLD3ruu+DHypx757UJ7cYYBvv7+GR1AvCF6ET41nhkiuuIskMjXwWxpXtx nXsA== X-Gm-Message-State: AOAM530P5d2VlwmbRSMDG+Dnp4g7mewR/ioQeFf1lYnShQOttOkPgM9s hAZ1eXRc+UW/x+K7soRlUVgBztza3R6/KK4Y0uA= X-Received: by 2002:a9d:1710:: with SMTP id i16mr3721277ota.260.1611069152634; Tue, 19 Jan 2021 07:12:32 -0800 (PST) MIME-Version: 1.0 References: <1803209.Mvru99baaF@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 19 Jan 2021 16:12:20 +0100 Message-ID: Subject: Re: [PATCH] x86: PM: Register syscore_ops for scale invariance To: "Rafael J. Wysocki" Cc: Peter Zijlstra , "Rafael J. Wysocki" , Linux PM , LKML , x86 Maintainers , Srinivas Pandruvada , Giovanni Gherdovich , Giovanni Gherdovich Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 4:10 PM Rafael J. Wysocki wrote: > > On Tue, Jan 12, 2021 at 4:02 PM Peter Zijlstra wrote: > > > > On Fri, Jan 08, 2021 at 07:05:59PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > On x86 scale invariace tends to be disabled during resume from > > > suspend-to-RAM, because the MPERF or APERF MSR values are not as > > > expected then due to updates taking place after the platform > > > firmware has been invoked to complete the suspend transition. > > > > > > That, of course, is not desirable, especially if the schedutil > > > scaling governor is in use, because the lack of scale invariance > > > causes it to be less reliable. > > > > > > To counter that effect, modify init_freq_invariance() to register > > > a syscore_ops object for scale invariance with the ->resume callback > > > pointing to init_counter_refs() which will run on the CPU starting > > > the resume transition (the other CPUs will be taken care of the > > > "online" operations taking place later). > > > > > > Fixes: e2b0d619b400 ("x86, sched: check for counters overflow in frequency invariant accounting") > > > Signed-off-by: Rafael J. Wysocki > > > > Thanks!, I'll take it through the sched/urgent tree? > > That works, thanks! Any news on this front? It's been a few days ...