Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Jan 2021 16:51:38 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Richard Weinberger <richard@nod.at>
Cc:     Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Boris Brezillon <bbrezillon@kernel.org>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFm?= =?UTF-8?B?YcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH 3/3] mtd: parsers: ofpart: support BCM4908 fixed
 partitions
Message-ID: <20210119165138.4982ae46@xps13>
In-Reply-To: <20210115153901.31052-3-zajec5@gmail.com>
References: <20210115153901.31052-1-zajec5@gmail.com>
        <20210115153901.31052-3-zajec5@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Rafał,

Rafał Miłecki <zajec5@gmail.com> wrote on Fri, 15 Jan 2021 16:39:01
+0100:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> BCM4908 partitioning is based on fixed layout but allows specifying
> multiple firmware partitions. It requires detecting which firmware
> partition was used for booting current kernel.
> 
> To support such cases without duplicating a lot of code (without copying
> most of the ofpart.c code) support for post-parsing callback was added.
> 
> BCM4908 callback simply reads offset of currently used firmware
> partition from the DT. Bootloader specifies it using the "brcm_blparms"
> property.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

The approach looks fine by me, let's see what other maintainers think.


Cheers,
Miquèl